Re: [PATCH] describe --contains: default to HEAD when no commit-ish is given

Quoting Junio C Hamano gits...@pobox.com: @@ -443,10 +443,13 @@ int cmd_describe(int argc, const char **argv, const char *prefix) if (pattern) argv_array_pushf(args, --refs=refs/tags/%s, pattern); } -

Re: [PATCH] describe --contains: default to HEAD when no commit-ish is given

SZEDER Gábor sze...@ira.uka.de writes: By the way, I usually prefer a fatter 'else' clause when everything else is equal, i.e. if (!argc) argv_array_push(args, HEAD); /* default to HEAD */ else { while (*argv) { ... }

[PATCH] describe --contains: default to HEAD when no commit-ish is given

'git describe --contains' doesn't default to HEAD when no commit is given, and it doesn't produce any output, not even an error: ~/src/git ((v2.5.0))$ ./git describe --contains ~/src/git ((v2.5.0))$ ./git describe --contains HEAD v2.5.0^0 Unlike other 'git describe' options, the

Re: [PATCH] describe --contains: default to HEAD when no commit-ish is given

SZEDER Gábor sze...@ira.uka.de writes: 'git describe --contains' doesn't default to HEAD when no commit is given, and it doesn't produce any output, not even an error: ~/src/git ((v2.5.0))$ ./git describe --contains ~/src/git ((v2.5.0))$ ./git describe --contains HEAD v2.5.0^0 Good