Re: [PATCH] diff: --color-moved: rename "dimmed_zebra" to "dimmed-zebra"

2018-07-25 Thread Eric Sunshine
On Tue, Jul 24, 2018 at 6:09 PM Jonathan Nieder wrote: > Eric Sunshine wrote: > > Subject: diff: --color-moved: rename "dimmed_zebra" to "dimmed-zebra" > > It would be clearer to say something like > > diff --color-moved: add "dimmed-zebra" synonym for "dimmed_zebra" That could work,

Re: [PATCH] diff: --color-moved: rename "dimmed_zebra" to "dimmed-zebra"

2018-07-24 Thread Stefan Beller
On Tue, Jul 24, 2018 at 3:09 PM Jonathan Nieder wrote: > Hm. Looks like dimmed_zebra was introduced in v2.15.0-rc0~16^2~2 > (2017-06-30), so it has been around for a while (about a year). But I > would like to be able to simplify by getting rid of it. > >

Re: [PATCH] diff: --color-moved: rename "dimmed_zebra" to "dimmed-zebra"

2018-07-24 Thread Jonathan Nieder
Eric Sunshine wrote: > Subject: diff: --color-moved: rename "dimmed_zebra" to "dimmed-zebra" It would be clearer to say something like diff --color-moved: add "dimmed-zebra" synonym for "dimmed_zebra" > The --color-moved "dimmed_zebra" mode (with an underscore) is an > anachronism.

[PATCH] diff: --color-moved: rename "dimmed_zebra" to "dimmed-zebra"

2018-07-24 Thread Eric Sunshine
The --color-moved "dimmed_zebra" mode (with an underscore) is an anachronism. Most options and modes are hyphenated. It is more difficult to type and somewhat more difficult to read than those which are hyphenated. Therefore, rename it to "dimmed-zebra", and nominally deprecate "dimmed_zebra".