Re: [PATCH] diff: alias -q to --quiet

2017-10-16 Thread Jeff King
On Sat, Oct 14, 2017 at 11:37:28AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > So there are two separate questions/tasks: > > > > 1. Should we remove the special handling of "-q" leftover from this > > deprecation? I think the answer is yes. > > > > 2. Should

Re: [PATCH] diff: alias -q to --quiet

2017-10-13 Thread Junio C Hamano
Jeff King writes: > So there are two separate questions/tasks: > > 1. Should we remove the special handling of "-q" leftover from this > deprecation? I think the answer is yes. > > 2. Should we teach the diff machinery as a whole to treat "-q" as a > synonym for

Re: [PATCH] diff: alias -q to --quiet

2017-10-13 Thread Jeff King
On Fri, Oct 13, 2017 at 09:44:15AM -0700, Anthony Sottile wrote: > Previously, `-q` was silently ignored: I'm not sure if is totally ignored. Normally if we have an unknown options we'd complain: $ git diff -x error: invalid option: -x but we don't with "-q". Why? In builtin/diff.c:471,

[PATCH] diff: alias -q to --quiet

2017-10-13 Thread Anthony Sottile
Previously, `-q` was silently ignored: Before: $ git diff -q -- Documentation/; echo $? diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt index a88c767..aa6e724 100644 --- a/Documentation/diff-options.txt +++ b/Documentation/diff-options.txt @@ -587,6 +587,7 @@