[PATCH] diff-no-index.c: rewrote read_directory() to use is_dot_or_dotdot() function.

2014-03-19 Thread Andrei Dinu
is_dot_or_dotdot() verifies if the name of the directory sent as parameter to this function is the same with '.' or '..' and returns 0 if that is true. There is unnecessary to iterate each character of the char* argument and verify it with strcmp because if there is a match that is at the

Re: [PATCH] diff-no-index.c: rewrote read_directory() to use is_dot_or_dotdot() function.

2014-03-19 Thread Eric Sunshine
Thanks for the submission. Comments below to give you a taste of the Git review process... On Wed, Mar 19, 2014 at 4:31 AM, Andrei Dinu mandrei.d...@gmail.com wrote: Subject: diff-no-index.c: rewrote read_directory() to use is_dot_or_dotdot() function. Use imperative tone: rewrite instead of