Re: [PATCH] diff.c: pass sign_index to emit_line_ws_markup

2018-10-12 Thread Johannes Schindelin
Hi Stefan, On Wed, 10 Oct 2018, Stefan Beller wrote: > Instead of passing the sign directly to emit_line_ws_markup, pass only the > index to lookup the sign in diff_options->output_indicators. > > Signed-off-by: Stefan Beller > --- > > I still have this patch laying around, it simplifies the

[PATCH] diff.c: pass sign_index to emit_line_ws_markup

2018-10-10 Thread Stefan Beller
Instead of passing the sign directly to emit_line_ws_markup, pass only the index to lookup the sign in diff_options->output_indicators. Signed-off-by: Stefan Beller --- I still have this patch laying around, it simplifies the diff code a tiny bit. Stefan diff.c | 12 +--- 1 file

Re: [PATCH] diff.c: pass sign_index to emit_line_ws_markup

2018-08-23 Thread Johannes Schindelin
Hi Stefan, On Wed, 22 Aug 2018, Stefan Beller wrote: > Instead of passing the sign directly to emit_line_ws_markup, pass only the > index to lookup the sign in diff_options->output_indicators. > > Signed-off-by: Stefan Beller Looks good to me! > --- > diff.c | 12 +--- > 1 file

[PATCH] diff.c: pass sign_index to emit_line_ws_markup

2018-08-22 Thread Stefan Beller
Instead of passing the sign directly to emit_line_ws_markup, pass only the index to lookup the sign in diff_options->output_indicators. Signed-off-by: Stefan Beller --- diff.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) So something like this on top of