Re: [PATCH] difftool: gracefully handle symlinks to directories

2015-10-27 Thread David Aguilar
On Thu, Oct 22, 2015 at 11:23:54AM -0700, Junio C Hamano wrote: > David Aguilar writes: > > > difftool's dir-diff feature was blindly feeding worktree paths > > to hash-object without checking whether the path was indeed a > > file, causing the feature to fail when repositories

Re: [PATCH] difftool: gracefully handle symlinks to directories

2015-10-22 Thread Junio C Hamano
David Aguilar writes: > difftool's dir-diff feature was blindly feeding worktree paths > to hash-object without checking whether the path was indeed a > file, causing the feature to fail when repositories contain > symlinks to directories. Wait. Anything that considers

[PATCH] difftool: gracefully handle symlinks to directories

2015-10-21 Thread David Aguilar
difftool's dir-diff feature was blindly feeding worktree paths to hash-object without checking whether the path was indeed a file, causing the feature to fail when repositories contain symlinks to directories. Ensure that only files are ever given to hash-object. Add a test to demonstrate the