Re: [PATCH] doc: State coding guideline for error message punctuation

2014-07-15 Thread Philip Oakley
From: Junio C Hamano gits...@pobox.com Sent: Thursday, July 10, 2014 9:36 PM Jeff King p...@peff.net writes: On Mon, Jun 16, 2014 at 01:55:57PM +0100, Philip Oakley wrote: +Error Messages + + - We typically do not end error messages with a full stop. While + we've been rather inconsistent

Re: [PATCH] doc: State coding guideline for error message punctuation

2014-07-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Mon, Jun 16, 2014 at 01:55:57PM +0100, Philip Oakley wrote: +Error Messages + + - We typically do not end error messages with a full stop. While + we've been rather inconsistent in the past, these days we mostly + settle on no punctuation. Unlike

Re: [PATCH] doc: State coding guideline for error message punctuation

2014-07-10 Thread Jeff King
On Thu, Jul 10, 2014 at 01:36:05PM -0700, Junio C Hamano wrote: Perhaps there are others (we do not have to be exhaustive, but it makes sense to think for a moment while we are here). I do not want to forever be waiting for a reroll, so let's queue this and advance it to 'next' soonish,

Re: [PATCH] doc: State coding guideline for error message punctuation

2014-06-17 Thread Jeff King
On Mon, Jun 16, 2014 at 01:55:57PM +0100, Philip Oakley wrote: +Error Messages + + - We typically do not end error messages with a full stop. While + we've been rather inconsistent in the past, these days we mostly + settle on no punctuation. Unlike Junio, I do not mind spelling out

[PATCH] doc: State coding guideline for error message punctuation

2014-06-16 Thread Philip Oakley
Clarify error message puntuation to reduce review workload [1]. [1] http://article.gmane.org/gmane.comp.version-control.git/251547 (see trailing 'nit' item). Signed-off-by: Philip Oakley philipoak...@iee.org --- Documentation/CodingGuidelines | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [PATCH] doc: State coding guideline for error message punctuation

2014-06-16 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: Clarify error message puntuation to reduce review workload [1]. [1] http://article.gmane.org/gmane.comp.version-control.git/251547 (see trailing 'nit' item). Signed-off-by: Philip Oakley philipoak...@iee.org --- Hmmm. Do we really need to spell

Re: [PATCH] doc: State coding guideline for error message punctuation

2014-06-16 Thread Philip Oakley
From: Junio C Hamano gits...@pobox.com Philip Oakley philipoak...@iee.org writes: Clarify error message puntuation to reduce review workload [1]. [1] http://article.gmane.org/gmane.comp.version-control.git/251547 (see trailing 'nit' item). Signed-off-by: Philip Oakley philipoak...@iee.org