[PATCH] doc: filter-branch does not require re-export of vars

2017-05-26 Thread Andreas Heiduk
The function `set_ident` in `filter-branch` exported the variables GIT_(AUTHOR|COMMITTER)_(NAME|EMAIL|DATE) at least since 6f6826c52b in 2007. Therefore the filter scripts don't need to re-eport them again. Signed-off-by: Andreas Heiduk --- Documentation/git-filter-branch.txt | 5 + 1 file c

Re: [PATCH] doc: filter-branch does not require re-export of vars

2017-05-26 Thread Jeff King
On Fri, May 26, 2017 at 07:36:54PM +0200, Andreas Heiduk wrote: > The function `set_ident` in `filter-branch` exported the variables > GIT_(AUTHOR|COMMITTER)_(NAME|EMAIL|DATE) at least since 6f6826c52b in 2007. > Therefore the filter scripts don't need to re-eport them again. Some old shells keep

Re: [PATCH] doc: filter-branch does not require re-export of vars

2017-05-28 Thread Junio C Hamano
Jeff King writes: > On Fri, May 26, 2017 at 07:36:54PM +0200, Andreas Heiduk wrote: > >> The function `set_ident` in `filter-branch` exported the variables >> GIT_(AUTHOR|COMMITTER)_(NAME|EMAIL|DATE) at least since 6f6826c52b in 2007. >> Therefore the filter scripts don't need to re-eport them ag

Re: [PATCH] doc: filter-branch does not require re-export of vars

2017-05-28 Thread Samuel Lijin
On Fri, May 26, 2017 at 2:37 PM, Jeff King wrote: > > On Fri, May 26, 2017 at 07:36:54PM +0200, Andreas Heiduk wrote: > > > The function `set_ident` in `filter-branch` exported the variables > > GIT_(AUTHOR|COMMITTER)_(NAME|EMAIL|DATE) at least since 6f6826c52b in 2007. > > Therefore the filter sc

Re: [PATCH] doc: filter-branch does not require re-export of vars

2017-05-28 Thread Jeff King
On Sun, May 28, 2017 at 09:35:30PM -0400, Samuel Lijin wrote: > > However, I think POSIX mandates the behavior you'd expect. And the only > > shell I know that misbehaves in this way is Solaris /bin/sh, which we > > have already declared too broken to support. > > Off-topic, but where is this exp

Re: [PATCH] doc: filter-branch does not require re-export of vars

2017-05-28 Thread Junio C Hamano
Samuel Lijin writes: >> However, I think POSIX mandates the behavior you'd expect. And the only >> shell I know that misbehaves in this way is Solaris /bin/sh, which we >> have already declared too broken to support. > > Off-topic, but where is this explicitly documented? One link I had readily

Re: [PATCH] doc: filter-branch does not require re-export of vars

2017-05-28 Thread Jeff King
On Mon, May 29, 2017 at 01:27:45PM +0900, Junio C Hamano wrote: > Samuel Lijin writes: > > >> However, I think POSIX mandates the behavior you'd expect. And the only > >> shell I know that misbehaves in this way is Solaris /bin/sh, which we > >> have already declared too broken to support. > > >