Re: [PATCH] dumb-http: do not pass NULL path to parse_pack_index

2015-01-27 Thread Charles Bailey
On Tue, Jan 27, 2015 at 03:02:27PM -0500, Jeff King wrote: Discovery and tests by Charles Bailey char...@hashpling.org. Signed-off-by: Jeff King p...@peff.net --- I'm happy to flip the authorship on this. You have more lines in it than I do. :) No, I'm happy with you taking the

Re: [PATCH] dumb-http: do not pass NULL path to parse_pack_index

2015-01-27 Thread Junio C Hamano
Charles Bailey char...@hashpling.org writes: On Tue, Jan 27, 2015 at 03:02:27PM -0500, Jeff King wrote: Discovery and tests by Charles Bailey char...@hashpling.org. Signed-off-by: Jeff King p...@peff.net --- I'm happy to flip the authorship on this. You have more lines in it than I do. :)

[PATCH] dumb-http: do not pass NULL path to parse_pack_index

2015-01-27 Thread Jeff King
On Tue, Jan 27, 2015 at 01:12:20PM -0500, Jeff King wrote: It looks like the culprit is 7b64469 (Allow parse_pack_index on temporary files, 2010-04-19). It added a new idx_path parameter to parse_pack_index, which we pass as NULL. That causes its call to check_packed_git_idx to fail (because