On Tue, Jun 2, 2015 at 11:28 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Wed, Jun 3, 2015 at 12:51 AM, Jeff King p...@peff.net wrote:
---
I'm also happy to split it into two patches, and make Eric the author on
the MASK part.
I don't mind being an author of a patch, so splitting
On Wed, Jun 03, 2015 at 02:28:10AM -0400, Eric Sunshine wrote:
On Wed, Jun 3, 2015 at 12:51 AM, Jeff King p...@peff.net wrote:
Subject: [PATCH] ewah: use less generic macro names
The ewah/ewok.h header pollutes the global namespace with
BITS_IN_WORD, without any specific notion that we
On Wed, Jun 3, 2015 at 12:51 AM, Jeff King p...@peff.net wrote:
Subject: [PATCH] ewah: use less generic macro names
The ewah/ewok.h header pollutes the global namespace with
BITS_IN_WORD, without any specific notion that we are
talking about the bits in an eword_t. We can give this the
more
On PowerPC Mac OS X (10.5.8 Leopard with Xcode 3.1), system header
/usr/include/ppc/param.h[1] pollutes the preprocessor namespace with a
macro generically named MASK. This conflicts with the same-named macro
in ewah/bitmap.c.
[1]: Included indirectly via:
git-compat-util.h -
Eric Sunshine sunsh...@sunshineco.com writes:
On PowerPC Mac OS X (10.5.8 Leopard with Xcode 3.1), system header
/usr/include/ppc/param.h[1] pollutes the preprocessor namespace with a
macro generically named MASK. This conflicts with the same-named macro
in ewah/bitmap.c.
[1]: Included
On Tue, Jun 02, 2015 at 03:15:09PM -0700, Junio C Hamano wrote:
The alternative is to rename MASK in ewah/bitmap.c to something less
generic, resulting in a slightly more noisy patch. I chose the #undef
approach since it's a relatively common idiom to #undef a macro before
#defining it in
6 matches
Mail list logo
