Re: [PATCH] fast-import: Don't count delta attempts against an empty buffer

Mike Hommey writes: > On Tue, Jul 03, 2018 at 11:41:42AM -0700, Junio C Hamano wrote: >> Mike Hommey writes: >> >> > When the reference buffer is empty, diff_delta returns NULL without >> > really attempting anything, yet fast-import counts that as a delta >> > attempt. >> >> But that is an at

Re: [PATCH] fast-import: Don't count delta attempts against an empty buffer

On Tue, Jul 03, 2018 at 11:41:42AM -0700, Junio C Hamano wrote: > Mike Hommey writes: > > > When the reference buffer is empty, diff_delta returns NULL without > > really attempting anything, yet fast-import counts that as a delta > > attempt. > > But that is an attempt nevertheless, no? Attemp

Re: [PATCH] fast-import: Don't count delta attempts against an empty buffer

Mike Hommey writes: > When the reference buffer is empty, diff_delta returns NULL without > really attempting anything, yet fast-import counts that as a delta > attempt. But that is an attempt nevertheless, no? Attempted and failed to find anything useful, that is. What problem are you trying

[PATCH] fast-import: Don't count delta attempts against an empty buffer

When the reference buffer is empty, diff_delta returns NULL without really attempting anything, yet fast-import counts that as a delta attempt. Signed-off-by: Mike Hommey --- fast-import.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fast-import.c b/fast-import.c index 4d5