Re: [PATCH] fast-import: avoid running end_packfile recursively

2015-02-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: When an import has finished, we run end_packfile() to finalize the data and move the packfile into place. If this process fails, we call die() and end up in our die_nicely() handler. Which unfortunately includes running end_packfile to save any progress we

Re: [PATCH] fast-import: avoid running end_packfile recursively

2015-02-10 Thread Jeff King
On Tue, Feb 10, 2015 at 10:45:20AM -0800, Junio C Hamano wrote: Unfortunately, it is not so easy. pack_data is a global, and end_packfile calls into other functions which operate on the global directly. We would have to teach each of these to take an argument, and there is no guarantee

[PATCH] fast-import: avoid running end_packfile recursively

2015-02-09 Thread Jeff King
When an import has finished, we run end_packfile() to finalize the data and move the packfile into place. If this process fails, we call die() and end up in our die_nicely() handler. Which unfortunately includes running end_packfile to save any progress we made. We enter the function again, and