Re: [PATCH] fast-import: properly fanout notes when tree is imported

2016-12-20 Thread Junio C Hamano
Mike Hommey writes: > In typical uses of fast-import, trees are inherited from a parent > commit. In that case, the tree_entry for the branch looks like: > ... > This change makes do_change_note_fanount call load_tree() whenever the > tree_entry it is given has no tree loaded,

Re: [PATCH] fast-import: properly fanout notes when tree is imported

2016-12-20 Thread Mike Hommey
Sorry, I forgot the v2 in the subject. Mike

[PATCH] fast-import: properly fanout notes when tree is imported

2016-12-20 Thread Mike Hommey
In typical uses of fast-import, trees are inherited from a parent commit. In that case, the tree_entry for the branch looks like: .versions[1].sha1 = $some_sha1 .tree = However, when trees are imported, rather than inherited, that is not the case. One can import a tree with a filemodify

Re: [PATCH] fast-import: properly fanout notes when tree is imported

2016-12-20 Thread Junio C Hamano
Mike Hommey writes: > On Tue, Dec 20, 2016 at 11:34:04AM -0800, Junio C Hamano wrote: >> Mike Hommey writes: >> >> > In typical uses of fast-import, trees are inherited from a parent >> > commit. In that case, the tree_entry for the branch looks like: >> >

Re: [PATCH] fast-import: properly fanout notes when tree is imported

2016-12-20 Thread Mike Hommey
On Tue, Dec 20, 2016 at 11:34:04AM -0800, Junio C Hamano wrote: > Mike Hommey writes: > > > In typical uses of fast-import, trees are inherited from a parent > > commit. In that case, the tree_entry for the branch looks like: > > ... > > +# Create another notes tree from the

Re: [PATCH] fast-import: properly fanout notes when tree is imported

2016-12-20 Thread Junio C Hamano
Mike Hommey writes: > In typical uses of fast-import, trees are inherited from a parent > commit. In that case, the tree_entry for the branch looks like: > ... > +# Create another notes tree from the one above > +cat >>input < +... > +M 04 $(git log --no-walk --format=%T

Re: [PATCH] fast-import: properly fanout notes when tree is imported

2016-12-19 Thread Johan Herland
On Mon, Dec 19, 2016 at 3:12 AM, Mike Hommey wrote: > In typical uses of fast-import, trees are inherited from a parent > commit. In that case, the tree_entry for the branch looks like: > > .versions[1].sha1 = $some_sha1 > .tree = > > However, when trees are imported,

[PATCH] fast-import: properly fanout notes when tree is imported

2016-12-18 Thread Mike Hommey
In typical uses of fast-import, trees are inherited from a parent commit. In that case, the tree_entry for the branch looks like: .versions[1].sha1 = $some_sha1 .tree = However, when trees are imported, rather than inherited, that is not the case. One can import a tree with a filemodify