Re: [PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-20 Thread Jeff King
On Thu, Jun 20, 2019 at 05:11:03PM +0700, Duy Nguyen wrote: > > Another option would be to just pass "-c gc.auto=0" to the child > > processes to inhibit auto-gc. But maybe it makes sense to have a nicer > > interface (after all, somebody else could be doing the same "let's do a > > bunch of fetch

Re: [PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-20 Thread Duy Nguyen
On Thu, Jun 20, 2019 at 1:59 AM Jeff King wrote: > I was surprised that we needed a new command-line option here, but I > guess the sub-fetch processes really have no idea that they're > subservient to a multi-remote fetch (they do get "--append", but of > course somebody could specify that indepe

Re: [PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-19 Thread Jeff King
On Wed, Jun 19, 2019 at 04:46:30PM +0700, Nguyễn Thái Ngọc Duy wrote: > In multiple remotes mode, git-fetch is launched for n-1 remotes and the > last remote is handled by the current process. Each of these processes > will in turn run 'gc' at the end. > > This is not really a problem because eve

[PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-19 Thread Nguyễn Thái Ngọc Duy
In multiple remotes mode, git-fetch is launched for n-1 remotes and the last remote is handled by the current process. Each of these processes will in turn run 'gc' at the end. This is not really a problem because even if multiple 'gc --auto' is run at the same time we still handle it correctly. I