Re: [PATCH] fetch-pack: unify ref in and out param

2018-08-02 Thread Jeff King
On Wed, Aug 01, 2018 at 01:13:20PM -0700, Jonathan Tan wrote: > When a user fetches: > - at least one up-to-date ref and at least one non-up-to-date ref, > - using HTTP with protocol v0 (or something else that uses the fetch >command of a remote helper) > some refs might not be updated

Re: [PATCH] fetch-pack: unify ref in and out param

2018-08-01 Thread Junio C Hamano
Brandon Williams writes: > ..., I expect we may need to do a bit more work on the whole > fetching stack to get what we'd want in that case (because we would want > to avoid this issue again). Amen. Thanks all.

Re: [PATCH] fetch-pack: unify ref in and out param

2018-08-01 Thread Brandon Williams
On 08/01, Jonathan Tan wrote: > When a user fetches: > - at least one up-to-date ref and at least one non-up-to-date ref, > - using HTTP with protocol v0 (or something else that uses the fetch >command of a remote helper) > some refs might not be updated after the fetch. > > This bug was

[PATCH] fetch-pack: unify ref in and out param

2018-08-01 Thread Jonathan Tan
When a user fetches: - at least one up-to-date ref and at least one non-up-to-date ref, - using HTTP with protocol v0 (or something else that uses the fetch command of a remote helper) some refs might not be updated after the fetch. This bug was introduced in commit 989b8c4452 ("fetch-pack: