[PATCH] fetch --all: pass --tags/--no-tags through to each remote

Reported-by: Oswald Buddenhagen Signed-off-by: Dan Johnson --- Junio C Hamano writes: >Dan Johnson writes: > >> I believe that is bad interaction with "--all" (probably a bug). If I >> am remembering correctly, --no-tags is internally a per-remote >> setting, so I'm guessing it's not getting s

Re: [PATCH] fetch --all: pass --tags/--no-tags through to each remote

On Sat, Sep 01, 2012 at 12:25:33AM -0400, Dan Johnson wrote: > diff --git a/builtin/fetch.c b/builtin/fetch.c > index bb9a074..c6bcbdc 100644 > --- a/builtin/fetch.c > +++ b/builtin/fetch.c > @@ -857,6 +857,10 @@ static void add_options_to_argv(int *argc, const char > **argv) > argv

Re: [PATCH] fetch --all: pass --tags/--no-tags through to each remote

Since the array struct stores a "const char **" argv member (for compatibility with most of our argv-taking functions), we have to cast away the const-ness when freeing its elements. However, we used the wrong type when doing so. It doesn't make a difference since free() take a void pointer anywa