Re: [PATCH] files-backend: unlock packed store only if locked

2018-02-07 Thread Junio C Hamano
Jonathan Tan writes: > On Wed, 7 Feb 2018 09:42:51 -0500 > Jeff King wrote: > >> But this all seemed strangely familiar... I think this is the same bug >> as: >> >> https://public-inbox.org/git/20180118143841.1a4c674d@novascotia/ >> >> which is

Re: [PATCH] files-backend: unlock packed store only if locked

2018-02-07 Thread Jonathan Tan
On Wed, 7 Feb 2018 09:42:51 -0500 Jeff King wrote: > But this all seemed strangely familiar... I think this is the same bug > as: > > https://public-inbox.org/git/20180118143841.1a4c674d@novascotia/ > > which is queued as mr/packed-ref-store-fix. It's listed as "will merge >

Re: [PATCH] files-backend: unlock packed store only if locked

2018-02-07 Thread Jeff King
On Tue, Feb 06, 2018 at 12:36:15PM -0800, Jonathan Tan wrote: > In commit 42c7f7ff9685 ("commit_packed_refs(): remove call to > `packed_refs_unlock()`", 2017-06-23), a call to packed_refs_unlock() was > added to files_initial_transaction_commit() in order to compensate for > removing that call

[PATCH] files-backend: unlock packed store only if locked

2018-02-06 Thread Jonathan Tan
In commit 42c7f7ff9685 ("commit_packed_refs(): remove call to `packed_refs_unlock()`", 2017-06-23), a call to packed_refs_unlock() was added to files_initial_transaction_commit() in order to compensate for removing that call from commit_packed_refs(). However, that call was added in the cleanup