Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-23 Thread Gabor Bernat
On Tue, Sep 22, 2015 at 6:08 PM, Junio C Hamano wrote: > Gabor Bernat writes: > >> On Mon, Sep 21, 2015 at 11:24 PM, Gábor Bernát >> ... >>> Agreed, :) did not abandoned this, just got caught up with many stuff. >>> Thanks for the help, >> >> So do I need to do anything else with this? :) > > If

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-22 Thread Junio C Hamano
Gabor Bernat writes: > On Mon, Sep 21, 2015 at 11:24 PM, Gábor Bernát > ... >> Agreed, :) did not abandoned this, just got caught up with many stuff. >> Thanks for the help, > > So do I need to do anything else with this? :) If you can fetch from me to see if the output from git log -p orig

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-22 Thread Gabor Bernat
On Mon, Sep 21, 2015 at 11:24 PM, Gábor Bernát wrote: > On Mon, Sep 21, 2015 at 11:22 PM, Eric Sunshine > wrote: >> >> On Mon, Sep 21, 2015 at 3:52 PM, Junio C Hamano wrote: >> > Eric Sunshine writes: >> >> On Tue, Sep 8, 2015 at 1:32 PM, Junio C Hamano >> >> wrote: >> >>> Eric Sunshine write

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-21 Thread Eric Sunshine
On Mon, Sep 21, 2015 at 3:52 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> On Tue, Sep 8, 2015 at 1:32 PM, Junio C Hamano wrote: >>> Eric Sunshine writes: On Mon, Sep 7, 2015 at 9:52 AM, Gábor Bernát wrote: ... > # Rewrite the commits > +report_progress () > +{ >>>

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-21 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, Sep 8, 2015 at 1:32 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >>> On Mon, Sep 7, 2015 at 9:52 AM, Gábor Bernát wrote: >>>... # Rewrite the commits +report_progress () +{ +if test -n "$progress" +then >>> >>> Indent code within

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-08 Thread Jeff King
On Tue, Sep 08, 2015 at 10:32:12AM -0700, Junio C Hamano wrote: > Also git_filter_branch__commit_count is now used only inside this > function, so it is easier to follow to increment it here. > > I suspect that the variable has this unwieldy name for historic > reasons, perhaps an attempt to avoi

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-08 Thread Eric Sunshine
On Tue, Sep 8, 2015 at 1:32 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> On Mon, Sep 7, 2015 at 9:52 AM, Gábor Bernát wrote: >>... >>> # Rewrite the commits >>> +report_progress () >>> +{ >>> +if test -n "$progress" >>> +then >> >> Indent code within the function... > > Also git_filter_

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-08 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Sep 7, 2015 at 9:52 AM, Gábor Bernát wrote: >... >> # Rewrite the commits >> +report_progress () >> +{ >> +if test -n "$progress" >> +then > > Indent code within the function... Also git_filter_branch__commit_count is now used only inside this function, so it is

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-07 Thread Eric Sunshine
On Mon, Sep 7, 2015 at 9:52 AM, Gábor Bernát wrote: > From: Gabor Bernat > > adds seconds progress and estimated seconds time if getting the current > timestamp is supported by the date +%s command > > Signed-off-by: Gabor Bernat > --- > diff --git a/git-filter-branch.sh b/git-filter-branch.sh >

[PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-07 Thread Gábor Bernát
From: Gabor Bernat adds seconds progress and estimated seconds time if getting the current timestamp is supported by the date +%s command Signed-off-by: Gabor Bernat --- I've submitted this first to this list as a feature request, however in the meantime with the help of Jeff King , Junio C Ha

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-07 Thread Ramsay Jones
On 07/09/15 13:31, Gábor Bernát wrote: > From: Gabor Bernat > > adds seconds progress and estimated seconds time if getting the current > timestamp is supported by the date %+s command s/%+s/+%s/ ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body

[PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-07 Thread Gábor Bernát
From: Gabor Bernat adds seconds progress and estimated seconds time if getting the current timestamp is supported by the date %+s command Signed-off-by: Gabor Bernat --- I've submitted this first to this list as a feature request, however in the meantime with the help of Jeff King , Junio C Ha

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-06 Thread Junio C Hamano
Gábor Bernát writes: > +if date '+%s' 2>/dev/null | grep -q '^[0-9][0-9]*$' > +then > + show_seconds=t > +else > + show_seconds= > +fi > + > +case "$show_seconds" in > +t) > + start_timestamp=$(date +%s) > + next_sample_at=0 > + ;; > +'') > + progress="" > + ;; > +esac

[PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-06 Thread Gábor Bernát
From: Gabor Bernat adds seconds progress and estimated seconds time if getting the current timestamp is supported by the date %+s command Signed-off-by: Gabor Bernat --- I've submitted this first to this list as a feature request, however in the meantime with the help of Jeff King , Junio C Ha

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-06 Thread Eric Sunshine
On Sun, Sep 6, 2015 at 5:49 AM, Gabor Bernat wrote: > On Fri, Sep 4, 2015 at 10:15 PM, Eric Sunshine > wrote: >> On Fri, Sep 4, 2015 at 2:34 PM, Junio C Hamano wrote: >>> Gábor Bernát writes: +echo $(date +%s) | grep -q '^[0-9]+$'; 2>/dev/null && show_seconds=t >>> >>> That is very stran

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-06 Thread Gabor Bernat
On Fri, Sep 4, 2015 at 10:15 PM, Eric Sunshine wrote: > On Fri, Sep 4, 2015 at 2:34 PM, Junio C Hamano wrote: >> Gábor Bernát writes: >>> +echo $(date +%s) | grep -q '^[0-9]+$'; 2>/dev/null && show_seconds=t >> >> That is very strange construct. I think you meant to say something >> like >> >>

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-04 Thread Eric Sunshine
On Fri, Sep 4, 2015 at 2:34 PM, Junio C Hamano wrote: > Gábor Bernát writes: >> +echo $(date +%s) | grep -q '^[0-9]+$'; 2>/dev/null && show_seconds=t > > That is very strange construct. I think you meant to say something > like > > if date '+%s' 2>/dev/null | grep -q '^[0-9][0-9]*$' >

Re: [PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-04 Thread Junio C Hamano
Gábor Bernát writes: > @@ -277,9 +277,43 @@ test $commits -eq 0 && die "Found nothing to rewrite" > # Rewrite the commits > > git_filter_branch__commit_count=0 This is not a new problem, but I wonder why we need such a cumbersomely long variable name. It is not like this is a part of some s

[PATCH] filter-branch: add passed/remaining seconds on progress

2015-09-04 Thread Gábor Bernát
From: Gabor Bernat adds seconds progress and estimated seconds time if getting the current timestamp is supported by the date %+s command Signed-off-by: Gabor Bernat --- I've submitted this first to this list as a feature request, however in the meantime with the help of Jeff King , Junio C Ha