Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-24 Thread Yuki Kokubun
>> "git filter-branch -- --all" print unwanted error messages when refs that >> cannot be used with ^0 exist. > > It is not incorrect per-se, but if I were writing this, I'd say > "... when refs that point at objects that are not committish" or > something like that, as that is much closer to

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-22 Thread Yuki Kokubun
> However, if we pre-filter to limit the refs in "$tempdir/heads" to > those that are committish (i.e. those that pass "$ref^0") like the > patch and subsequent discussion suggests, wouldn't we lose the > warning for these replace refs and non-committish tags. We perhaps > could do something

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-22 Thread Junio C Hamano
Yuki Kokubun writes: >> Yuki Kokubun writes: >> >> >> Yuki Kokubun writes: >> >> >> >> > "git filter-branch -- --all" can be confused when refs that refer to >> >> > objects >> >> > other than commits or tags exists.

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-22 Thread Yuki Kokubun
> Yuki Kokubun writes: > > >> Yuki Kokubun writes: > >> > >> > "git filter-branch -- --all" can be confused when refs that refer to > >> > objects > >> > other than commits or tags exists. > >> > Because "git rev-parse --all" that is

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-21 Thread Junio C Hamano
Yuki Kokubun writes: >> Yuki Kokubun writes: >> >> > "git filter-branch -- --all" can be confused when refs that refer to >> > objects >> > other than commits or tags exists. >> > Because "git rev-parse --all" that is internally used can

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-21 Thread Yuki Kokubun
> Yuki Kokubun writes: > > > "git filter-branch -- --all" can be confused when refs that refer to objects > > other than commits or tags exists. > > Because "git rev-parse --all" that is internally used can return refs that > > refer to an object other than commit or

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-21 Thread Junio C Hamano
Yuki Kokubun writes: > "git filter-branch -- --all" can be confused when refs that refer to objects > other than commits or tags exists. > Because "git rev-parse --all" that is internally used can return refs that > refer to an object other than commit or tag. But it is

[PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-21 Thread Yuki Kokubun
"git filter-branch -- --all" can be confused when refs that refer to objects other than commits or tags exists. Because "git rev-parse --all" that is internally used can return refs that refer to an object other than commit or tag. But it is not considered in the phase of updating refs. Such refs