Re: [PATCH] filter-branch: use printf instead of echo -e

2018-03-20 Thread Michele Locati
Il 20/03/2018 10:53, Ian Campbell ha scritto: On Tue, 2018-03-20 at 00:22 -0400, Jeff King wrote: Author cc'd in case there's something more interesting going on. That code was written years ago, if I had a good reason at the time I've forgotten what it was and I can't think of a fresh one

Re: [PATCH] filter-branch: use printf instead of echo -e

2018-03-20 Thread Ian Campbell
On Tue, 2018-03-20 at 00:22 -0400, Jeff King wrote: > Author cc'd in case there's something more interesting going on. That code was written years ago, if I had a good reason at the time I've forgotten what it was and I can't think of a fresh one now. Switching to printf seems like a reasonable

Re: [PATCH] filter-branch: use printf instead of echo -e

2018-03-19 Thread Jeff King
On Mon, Mar 19, 2018 at 03:39:46PM +, CB Bailey wrote: > > diff --git a/git-filter-branch.sh b/git-filter-branch.sh > > index 1b7e4b2cd..21d84eff3 100755 > > --- a/git-filter-branch.sh > > +++ b/git-filter-branch.sh > > @@ -627,7 +627,7 @@ then > > print H

Re: [PATCH] filter-branch: use printf instead of echo -e

2018-03-19 Thread CB Bailey
On Mon, Mar 19, 2018 at 03:49:05PM +0100, Michele Locati wrote: > In order to echo a tab character, it's better to use printf instead of > "echo -e", because it's more portable (for instance, "echo -e" doesn't work > as expected on a Mac). > > This solves the "fatal: Not a valid object name"

[PATCH] filter-branch: use printf instead of echo -e

2018-03-19 Thread Michele Locati
In order to echo a tab character, it's better to use printf instead of "echo -e", because it's more portable (for instance, "echo -e" doesn't work as expected on a Mac). This solves the "fatal: Not a valid object name" error in git-filter-branch when using the --state-branch option.