Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Junio C Hamano writes: > ... > So, let's give Pranit a concrete "here is what we want to see > squashed in", while you guys discuss peculiarity with various > platforms and their system headers, which admittedly is a more > interesting tangent ;-) > > There are early returns

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Hey Junio, On Tue, Feb 14, 2017 at 12:44 AM, Junio C Hamano wrote: > René Scharfe writes: > >> Initializing to NULL is still the correct thing to do, of course -- >> together with removing the conditionals (or at least the negations). > > So, let's give Pranit a

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

René Scharfe writes: > Initializing to NULL is still the correct thing to do, of course -- > together with removing the conditionals (or at least the negations). So, let's give Pranit a concrete "here is what we want to see squashed in", while you guys discuss peculiarity with

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Am 13.02.2017 um 17:23 schrieb Johannes Schindelin: > Hi René, > > On Fri, 10 Feb 2017, René Scharfe wrote: > >> Am 10.02.2017 um 15:20 schrieb Johannes Schindelin: >>> It is curious that only MacOSX builds trigger an error about this, both >>> GCC and Clang, but not Linux GCC nor Clang (see >>>

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Hi René, On Fri, 10 Feb 2017, René Scharfe wrote: > Am 10.02.2017 um 15:20 schrieb Johannes Schindelin: > > It is curious that only MacOSX builds trigger an error about this, both > > GCC and Clang, but not Linux GCC nor Clang (see > > https://travis-ci.org/git/git/jobs/200182819#L1152 for

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Am 10.02.2017 um 15:20 schrieb Johannes Schindelin: It is curious that only MacOSX builds trigger an error about this, both GCC and Clang, but not Linux GCC nor Clang (see https://travis-ci.org/git/git/jobs/200182819#L1152 for details): builtin/bisect--helper.c:299:6: error: variable 'good_syn'

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Hey Johannes, On Fri, Feb 10, 2017 at 7:50 PM, Johannes Schindelin wrote: > > It is curious that only MacOSX builds trigger an error about this, both > GCC and Clang, but not Linux GCC nor Clang (see > https://travis-ci.org/git/git/jobs/200182819#L1152 for details): >

[PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

It is curious that only MacOSX builds trigger an error about this, both GCC and Clang, but not Linux GCC nor Clang (see https://travis-ci.org/git/git/jobs/200182819#L1152 for details): builtin/bisect--helper.c:299:6: error: variable 'good_syn' is used uninitialized whenever 'if'