[PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Junio C Hamano
From: Jeff King p...@peff.net Date: Fri, 29 Aug 2014 16:31:46 -0400 Upon finding a corrupt loose object, we forgot to note the error to signal it with the exit status of the entire process. [jc: adjusted t1450 and added another test] Signed-off-by: Junio C Hamano gits...@pobox.com --- * I

Re: [PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Jeff King
On Tue, Sep 09, 2014 at 03:03:33PM -0700, Junio C Hamano wrote: From: Jeff King p...@peff.net Date: Fri, 29 Aug 2014 16:31:46 -0400 Upon finding a corrupt loose object, we forgot to note the error to signal it with the exit status of the entire process. [jc: adjusted t1450 and added

Re: [PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: From: Jeff King p...@peff.net Date: Fri, 29 Aug 2014 16:31:46 -0400 Upon finding a corrupt loose object, we forgot to note the error to signal it with the exit status of the entire process. [jc: adjusted t1450 and added another test] Spoke too

Re: [PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Jonathan Nieder
Junio C Hamano wrote: By the way, Jonathan, with dbedf8bf (t1450 (fsck): remove dangling objects, 2010-09-06) you added a 'test_might_fail git fsck' to the 1450 test that catches an object corruption. Do you remember if there was some flakiness in this test that necessitated it, or is it