[PATCH] fsck: warn about ".git" in trees

2012-11-28 Thread Jeff King
pinion on warning about '.git', as well? It probably > > would make more sense as a patch on top, but I thought I'd ask before > > this got merged to next. > > Yeah, it would make sense to reject what we would not record > ourselves when the tools are used in

Re: [PATCH] fsck: warn about ".git" in trees

2012-11-30 Thread Torsten Bögershausen
Having a ".git" entry inside a tree can cause confusing results on checkout. At the top-level, you could not checkout such a tree, as it would complain about overwriting the real ".git" directory. In a subdirectory, you might check it out, but performing operations in the subdirectory would confus

Re: [PATCH] fsck: warn about ".git" in trees

2012-11-30 Thread Jeff King
On Fri, Nov 30, 2012 at 08:50:41PM +0100, Torsten Bögershausen wrote: > >Having a ".git" entry inside a tree can cause confusing > >results on checkout. At the top-level, you could not > >checkout such a tree, as it would complain about overwriting > >the real ".git" directory. In a subdirectory,

Re: [PATCH] fsck: warn about ".git" in trees

2012-12-04 Thread Andreas Ericsson
On 11/30/2012 08:50 PM, Torsten Bögershausen wrote: >> Having a ".git" entry inside a tree can cause confusing >> results on checkout. At the top-level, you could not >> checkout such a tree, as it would complain about overwriting >> the real ".git" directory. In a subdirectory, you might >> check