Re: [PATCH] fsck.c:fsck_commit() use starts_with() and skip_prefix()

2014-03-19 Thread Eric Sunshine
On Wed, Mar 19, 2014 at 5:04 AM, Othman Darraz darraz...@gmail.com wrote: 2014-03-19 0:12 GMT+01:00 Eric Sunshine sunsh...@sunshineco.com: On Tue, Mar 18, 2014 at 7:09 PM, Eric Sunshine sunsh...@sunshineco.com wrote: diff --git a/fsck.c b/fsck.c index 64bf279..5eae856 100644 --- a/fsck.c

[PATCH] fsck.c:fsck_commit() use starts_with() and skip_prefix()

2014-03-18 Thread Othman Darraz
use of starts_with() instead of memcmp() use of skip_prefix instead of memcmp() and strlen() Signed-off-by: Othman Darraz darraz...@gmail.com --- I am planning to apply to GSOC 214 fsck.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fsck.c b/fsck.c index

Re: [PATCH] fsck.c:fsck_commit() use starts_with() and skip_prefix()

2014-03-18 Thread Eric Sunshine
Thanks for the submission. Comments below to give you a taste of the Git review process... On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz darraz...@gmail.com wrote: use of starts_with() instead of memcmp() use of skip_prefix instead of memcmp() and strlen() Write proper sentences to explain

Re: [PATCH] fsck.c:fsck_commit() use starts_with() and skip_prefix()

2014-03-18 Thread Eric Sunshine
On Tue, Mar 18, 2014 at 7:09 PM, Eric Sunshine sunsh...@sunshineco.com wrote: diff --git a/fsck.c b/fsck.c index 64bf279..5eae856 100644 --- a/fsck.c +++ b/fsck.c @@ -290,7 +290,7 @@ static int fsck_commit(struct commit *commit, fsck_error error_func) int parents = 0; int

Re: [PATCH] fsck.c:fsck_commit() use starts_with() and skip_prefix()

2014-03-18 Thread Michael Haggerty
On 03/19/2014 12:09 AM, Eric Sunshine wrote: Thanks for the submission. Comments below to give you a taste of the Git review process... On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz darraz...@gmail.com wrote: use of starts_with() instead of memcmp() use of skip_prefix instead of memcmp()