Re: [PATCH] gc --auto: release pack files before auto packing

2018-07-11 Thread Duy Nguyen
On Mon, Jul 9, 2018 at 11:10 PM Junio C Hamano wrote: > > Duy Nguyen writes: > > > On Sun, Jul 8, 2018 at 1:16 AM Kim Gybels wrote: > >> Should I post a v3 that goes back to the original fix, but uses > >> test_i18ngrep instead of grep? > > > > Yes please. In my comment I did write we didn't nee

Re: [PATCH] gc --auto: release pack files before auto packing

2018-07-09 Thread Junio C Hamano
Duy Nguyen writes: > On Sun, Jul 8, 2018 at 1:16 AM Kim Gybels wrote: >> Should I post a v3 that goes back to the original fix, but uses >> test_i18ngrep instead of grep? > > Yes please. In my comment I did write we didn't need the repo anymore > (or something along that line) which turns out to

Re: [PATCH] gc --auto: release pack files before auto packing

2018-07-09 Thread Duy Nguyen
On Sun, Jul 8, 2018 at 1:16 AM Kim Gybels wrote: > Should I post a v3 that goes back to the original fix, but uses > test_i18ngrep instead of grep? Yes please. In my comment I did write we didn't need the repo anymore (or something along that line) which turns out to be wrong. > In addition to n

Re: [PATCH] gc --auto: release pack files before auto packing

2018-07-07 Thread Kim Gybels
On (07/07/18 11:40), SZEDER Gábor wrote: > > On Fri, Jul 6, 2018 at 6:39 PM Junio C Hamano wrote: > > > > Duy Nguyen writes: > > > > > On Sat, Jun 30, 2018 at 03:38:21PM +0200, Kim Gybels wrote: > > >> Teach gc --auto to release pack files before auto packing the repository > > >> to prevent fai

Re: [PATCH] gc --auto: release pack files before auto packing

2018-07-07 Thread SZEDER Gábor
On Fri, Jul 6, 2018 at 6:39 PM Junio C Hamano wrote: > > Duy Nguyen writes: > > > On Sat, Jun 30, 2018 at 03:38:21PM +0200, Kim Gybels wrote: > >> Teach gc --auto to release pack files before auto packing the repository > >> to prevent failures when removing them. > >> > >> Also teach the test 'f

Re: [PATCH] gc --auto: release pack files before auto packing

2018-07-06 Thread Junio C Hamano
Duy Nguyen writes: > On Sat, Jun 30, 2018 at 03:38:21PM +0200, Kim Gybels wrote: >> Teach gc --auto to release pack files before auto packing the repository >> to prevent failures when removing them. >> >> Also teach the test 'fetching with auto-gc does not lock up' to complain >> when it is no

Re: [PATCH] gc --auto: release pack files before auto packing

2018-06-30 Thread Duy Nguyen
On Sat, Jun 30, 2018 at 03:38:21PM +0200, Kim Gybels wrote: > Teach gc --auto to release pack files before auto packing the repository > to prevent failures when removing them. > > Also teach the test 'fetching with auto-gc does not lock up' to complain > when it is no longer triggering an auto pa

[PATCH] gc --auto: release pack files before auto packing

2018-06-30 Thread Kim Gybels
Teach gc --auto to release pack files before auto packing the repository to prevent failures when removing them. Also teach the test 'fetching with auto-gc does not lock up' to complain when it is no longer triggering an auto packing of the repository. Fixes https://github.com/git-for-windows/git