Re: [PATCH] git-completion: add stashes for gitk

2015-03-13 Thread Sveinung Kvilhaugsvik
Thank you for the review. I now understand that the commit message should have provided way more context about my use case. I used Bazaar almost exclusively until about a year ago. Git's ability to put stuff in the index without committing and the power of git rebase covers many of the use cases

Re: [PATCH] git-completion: add stashes for gitk

2015-03-13 Thread Junio C Hamano
Sveinung Kvilhaugsvik sveinun...@users.sourceforge.net writes: A bigger question is why this change is made to gitk completion. If this completion were useful for gitk, wouoldn't it be equally useful for git log? I must admit that I didn't know that git log could display the content of a

Re: [PATCH] git-completion: add stashes for gitk

2015-03-12 Thread Junio C Hamano
Sveinung Kvilhaugsvik sveinun...@users.sourceforge.net writes: Auto complete stashed modifications for gitk. This makes them easier to discover and faster to view. Signed-off-by: Sveinung Kvilhaugsvik sveinun...@users.sourceforge.net --- contrib/completion/git-completion.bash | 2 ++ 1

Re: [PATCH] git-completion: add stashes for gitk

2015-03-12 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: ... Also, when you have no ref that is named es-tee something, gitk stTAB completes to gitk stash@{, as if the problem the change tries to cure is it is unnecessarily hard to type at-mark open-brace. I do not have to be the target audience, though.

[PATCH] git-completion: add stashes for gitk

2015-03-11 Thread Sveinung Kvilhaugsvik
Auto complete stashed modifications for gitk. This makes them easier to discover and faster to view. Signed-off-by: Sveinung Kvilhaugsvik sveinun...@users.sourceforge.net --- contrib/completion/git-completion.bash | 2 ++ 1 file changed, 2 insertions(+) diff --git