Re: [PATCH] git-cvsimport: allow author-specific timezones

2012-10-16 Thread Jeff King
On Mon, Oct 15, 2012 at 08:50:21PM -0700, Junio C Hamano wrote: Chris Rorvick ch...@rorvick.com writes: It occurred to me that the success of the unit test depends on the host platform's zoneinfo database. I think this problem is inherent with this functionality. Should the unit test

Re: [PATCH] git-cvsimport: allow author-specific timezones

2012-10-16 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Mon, Oct 15, 2012 at 08:50:21PM -0700, Junio C Hamano wrote: Chris Rorvick ch...@rorvick.com writes: It occurred to me that the success of the unit test depends on the host platform's zoneinfo database. I think this problem is inherent with this

Re: [PATCH] git-cvsimport: allow author-specific timezones

2012-10-15 Thread Junio C Hamano
Chris Rorvick crorv...@cogcap.com writes: From: Chris Rorvick ch...@rorvick.com CVS patchsets are imported with timestamps having an offset of + (UTC). The cvs-authors file is already used to translate the CVS username to full name and email in the corresponding commit. Extend this

Re: [PATCH] git-cvsimport: allow author-specific timezones

2012-10-15 Thread Chris Rorvick
On Mon, Oct 15, 2012 at 12:40 PM, Junio C Hamano gits...@pobox.com wrote: diff --git a/t/t9604-cvsimport-timestamps.sh b/t/t9604-cvsimport-timestamps.sh new file mode 100644 Huh? What happened to the executable bit we saw earlier? Uh, yeah. Sorry about that. +test_expect_success 'check

Re: [PATCH] git-cvsimport: allow author-specific timezones

2012-10-15 Thread Junio C Hamano
Chris Rorvick ch...@rorvick.com writes: It occurred to me that the success of the unit test depends on the host platform's zoneinfo database. I think this problem is inherent with this functionality. Should the unit test attempt to detect support for the used timezones and short circuit if