Re: [PATCH] git-p4: Add failing test case for name-rev vs symbolic-ref

2017-03-27 Thread Junio C Hamano
Luke Diamand writes: > Yes. The test passes with your change. >> >> IOW, can we have a follow up to this patch that fixes a known >> breakage the patch documents ;-)? > > Yes. Thanks.

Re: [PATCH] git-p4: Add failing test case for name-rev vs symbolic-ref

2017-03-27 Thread Luke Diamand
On 27 March 2017 at 00:18, Junio C Hamano wrote: > Luke Diamand writes: > >> As per the discussion about use of "git name-rev" vs "git symbolic-ref" in >> git-p4 here: >> >> http://marc.info/?l=git=148979063421355 >> >> git-p4 could get confused about the

Re: [PATCH] git-p4: Add failing test case for name-rev vs symbolic-ref

2017-03-26 Thread Junio C Hamano
Luke Diamand writes: > As per the discussion about use of "git name-rev" vs "git symbolic-ref" in > git-p4 here: > > http://marc.info/?l=git=148979063421355 > > git-p4 could get confused about the branch it is on and affects > the git-p4.allowSubmit option. This adds a failing

[PATCH] git-p4: Add failing test case for name-rev vs symbolic-ref

2017-03-26 Thread Luke Diamand
As per the discussion about use of "git name-rev" vs "git symbolic-ref" in git-p4 here: http://marc.info/?l=git=148979063421355 git-p4 could get confused about the branch it is on and affects the git-p4.allowSubmit option. This adds a failing test case for the problem. Luke Diamand (1):