Re: [PATCH] git-p4: Fetch the proper revision of utf16 files

2015-04-03 Thread Eric Sunshine
On Fri, Apr 3, 2015 at 5:13 PM, Daniel Bingham dan...@dbingham.com wrote: git-p4 always fetches the latest revision of UTF16 files from P4 rather than the revision at the commit being sync'd. The print command should, instead, specify the revision number from the commit in question using the

[PATCH] git-p4: Fetch the proper revision of utf16 files

2015-04-03 Thread Daniel Bingham
I discovered what appears to be a bug with the handling of utf16 type files when cloning from P4. It appears that it always fetches the content of the latest version rather than getting the revision specified in the changelist being processed. This patch is an attempt to resolve that by

[PATCH] git-p4: Fetch the proper revision of utf16 files

2015-04-03 Thread Daniel Bingham
git-p4 always fetches the latest revision of UTF16 files from P4 rather than the revision at the commit being sync'd. The print command should, instead, specify the revision number from the commit in question using the file#revision syntax. The file#revision syntax is preferable over

Re: [PATCH] git-p4: Fetch the proper revision of utf16 files

2015-04-03 Thread Domain Admin
*note* I tried to send this to the list earlier but forgot to set the mode to plain-text so it got rejected. Resending. Apologies for any duplicates. I think the context of the patch doesn't make this clear, but if you look at git-p4.py in this spot you'll see that this is in a block that

Re: [PATCH] git-p4: Fetch the proper revision of utf16 files

2015-04-03 Thread Eric Sunshine
[Daniel: Your HTML-formatted response probably did not make it to the Git mailing list since only plain text is accepted. Also, please respond inline on this list rather than top-posting.] On Fri, Apr 3, 2015 at 5:54 PM, Domain Admin dan...@dbingham.com wrote: I think the context of the patch