Re: [PATCH] git-p4: Fix depot path stripping

Yes, that's where we left off. I owe you better testing of the clientspec-side path remapping case, which I hope to get to soon. Will get back to you as soon as I can. Thanks, Nuno On Fri, Mar 2, 2018 at 2:09 AM, Luke Diamand wrote: > On 27 February 2018 at 19:00, Nuno Subtil

Re: [PATCH] git-p4: Fix depot path stripping

On 27 February 2018 at 19:00, Nuno Subtil wrote: > I originally thought this had been designed such that the p4 client spec > determines the paths, which would make sense. However, git-p4 still ignores > the local path mappings in the client spec when syncing p4 depot paths >

Re: [PATCH] git-p4: Fix depot path stripping

On 27 February 2018 at 08:43, Nuno Subtil wrote: > The issue is that passing in --use-client-spec will always cause git-p4 to > preserve the full depot path in the working tree that it creates, even when > --keep-path is not used. > > The repro case is fairly simple: cloning a

Re: [PATCH] git-p4: Fix depot path stripping

On 27 February 2018 at 04:16, Nuno Subtil wrote: > When useClientSpec=true, stripping of P4 depot paths doesn't happen > correctly on sync. Modifies stripRepoPath to handle this case better. Can you give an example of how this shows up? I could quickly write a test case for

[PATCH] git-p4: Fix depot path stripping

When useClientSpec=true, stripping of P4 depot paths doesn't happen correctly on sync. Modifies stripRepoPath to handle this case better. Signed-off-by: Nuno Subtil --- git-p4.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/git-p4.py