Hi Etienne,
thanks for reporting this! Junio is right, I messed that up on my Windows
testing box! :-( Sorry!
If you have any questions around submitting patches I am happy to help as I
just recently went through the learning process myself!
@Dennis: Thanks for the quick patch!
Thanks,
Lars
I was wrong, the script doesn't work on my machine if ctypes is not
imported regardless of python version. I guess I was confused by using
a version of git-p4 before ctypes was introduced, the failing version
and the patched version, as well as several python versions.
Sorry for this misleading cl
Hello,
I couldn't work further on this yesterday (but I read
Documentation/SubmittingPatches, which is a good start I guess). The
diff proposed by Dennis works on my machine, I'll try to figure out
why the original script worked with 2.7.10.
Thanks
2015-10-21 1:00 GMT+02:00 Luke Diamand :
> On 2
On 20/10/15 20:36, Junio C Hamano wrote:
Dennis Kaarsemaker writes:
I do not follow Python development, but does the above mean that
with recent 2.x you can say ctypes without first saying "import
ctypes"? It feels somewhat non-pythonesque that identifiers like
this is given to you without yo
Dennis Kaarsemaker writes:
>> I do not follow Python development, but does the above mean that
>> with recent 2.x you can say ctypes without first saying "import
>> ctypes"? It feels somewhat non-pythonesque that identifiers like
>> this is given to you without you asking with an explicit 'impor
The ctypes module is used on windows to calculate free disk space, so it
must be imported.
Signed-off-by: Dennis Kaarsemaker
---
git-p4.py | 1 +
1 file changed, 1 insertion(+)
On di, 2015-10-20 at 09:00 -0700, Junio C Hamano wrote:
> Luke Diamand writes:
>
> > On 20 October 2015 at 11:34, Et
6 matches
Mail list logo