Re: [PATCH] git-send-email: Cc more people

2018-04-20 Thread Mathieu Desnoyers
- On Apr 19, 2018, at 8:03 PM, Junio C Hamano gits...@pobox.com wrote: > Mathieu Desnoyers writes: > I'd further say that these new CC-sources should be disabled by default and made opt-in to avoid surprising existing users. >>> >>> But I disagree

Re: [PATCH] git-send-email: Cc more people

2018-04-19 Thread Junio C Hamano
Mathieu Desnoyers writes: >>> I'd further say that these new CC-sources should be disabled by >>> default and made opt-in to avoid surprising existing users. >> >> But I disagree with this. The current behaviour is surprising to >> existing users, to the point

Re: [PATCH] git-send-email: Cc more people

2018-04-19 Thread Mathieu Desnoyers
- On Apr 19, 2018, at 8:10 AM, Matthew Wilcox wi...@infradead.org wrote: > On Thu, Apr 19, 2018 at 06:21:42AM +0900, Junio C Hamano wrote: >> Ævar Arnfjörð Bjarmason writes: >> >> > But IMO this patch is really lacking a few things before being ready: >> > >> > 1. You have

Re: [PATCH] git-send-email: Cc more people

2018-04-19 Thread Matthew Wilcox
On Thu, Apr 19, 2018 at 06:21:42AM +0900, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > But IMO this patch is really lacking a few things before being ready: > > > > 1. You have no tests for this. See t/t9001-send-email.sh for examples, > > ... > > 2. Just a few

Re: [PATCH] git-send-email: Cc more people

2018-04-18 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > But IMO this patch is really lacking a few things before being ready: > > 1. You have no tests for this. See t/t9001-send-email.sh for examples, > ... > 2. Just a few lines down from your quoted hunk we have this: > ... code about $supress_cc{}

Re: [PATCH] git-send-email: Cc more people

2018-04-18 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 18 2018, Matthew Wilcox wrote: > From: Matthew Wilcox > > Several of my colleagues (and myself) have expressed surprise and > annoyance that git-send-email doesn't automatically pick up people who > are listed in patches as Reported-by: or Reviewed-by: or ...

Re: [PATCH] git-send-email: Cc more people

2018-04-18 Thread Mathieu Desnoyers
- On Apr 18, 2018, at 10:33 AM, rostedt rost...@goodmis.org wrote: > On Wed, 18 Apr 2018 07:05:03 -0700 > Matthew Wilcox wrote: > >> From: Matthew Wilcox >> >> Several of my colleagues (and myself) have expressed surprise and >> annoyance that

Re: [PATCH] git-send-email: Cc more people

2018-04-18 Thread Steven Rostedt
On Wed, 18 Apr 2018 07:05:03 -0700 Matthew Wilcox wrote: > From: Matthew Wilcox > > Several of my colleagues (and myself) have expressed surprise and > annoyance that git-send-email doesn't automatically pick up people who > are listed in patches as

[PATCH] git-send-email: Cc more people

2018-04-18 Thread Matthew Wilcox
From: Matthew Wilcox Several of my colleagues (and myself) have expressed surprise and annoyance that git-send-email doesn't automatically pick up people who are listed in patches as Reported-by: or Reviewed-by: or ... many other tags that would seem (to us) to indicate