[PATCH] git-send-pack: Fix --all option when used with directory

2016-03-23 Thread Stanislav Kolotinskiy
When using git send-pack with --all option and a target directory, usage message is being displayed instead of performing the actual transmission. The reason for this issue is that refspecs variable is being calculated in a different way comparing to previous versions, and even though the number o

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-23 Thread Jeff King
On Wed, Mar 23, 2016 at 06:24:22PM +0200, Stanislav Kolotinskiy wrote: > When using git send-pack with --all option > and a target directory, usage message is being > displayed instead of performing the actual transmission. Yeah, that seems very wrong. Not that it matters for this bug, but for m

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-23 Thread Jeff King
On Wed, Mar 23, 2016 at 05:22:13PM -0400, Jeff King wrote: > > diff --git a/t/t9904-send-pack-all.sh b/t/t9904-send-pack-all.sh > > The tests are roughly grouped by functionality. send-pack tests are in > the t540x range, and this should probably go there. Though I also > suspect it could easily

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
On 23/03/16 23:22, Jeff King wrote: Not that it matters for this bug, but for my own curiosity, what do you use "send-pack --all" for? I've generally assumed that nobody directly calls send-pack themselves these days, but of course we have no data to support that either way. So I am always intere

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Junio C Hamano
Stanislav Kolotinskiy writes: > Subject: Re: [PATCH] git-send-pack: Fix --all option when used with directory Please see "git shortlog --no-merges" output from recent history and notice that s/Fix/fix/ would make things more consistent. > When using git send-pack with --all opt

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Jeff King
On Thu, Mar 24, 2016 at 03:57:59PM +0200, Stanislav Kolotinskiy wrote: > On 23/03/16 23:22, Jeff King wrote: > >Not that it matters for this bug, but for my own curiosity, what do you > >use "send-pack --all" for? I've generally assumed that nobody directly > >calls send-pack themselves these days

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
On 24/03/16 18:11, Junio C Hamano wrote: Please see "git shortlog --no-merges" output from recent history and notice that s/Fix/fix/ would make things more consistent. Thanks for letting me know, I'll update that. Thanks for noticing; the above explanation however does not make it very clear wh

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
On 24/03/16 19:37, Jeff King wrote: I guess a follow-up to my question is: what does "git send-pack" do that "git push" does not? Again, this is just for my curiosity (the answer may be "nothing, we just happened to build our scripts around send-pack", and that is perfectly fine). Well, this is s

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Jeff King
On Thu, Mar 24, 2016 at 07:47:12PM +0200, Stanislav Kolotinskiy wrote: > >Thanks for noticing; the above explanation however does not make it > >very clear why the symptom exhibits itself only when "directory" is > >given (it also is unclear if "target" being a directory is special, > >or if any r

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-04-01 Thread Stanislav Kolotinskiy
Thanks a lot, Jeff, your explanation really helped! -- Regards, Stanislav On 24/03/16 20:02, Jeff King wrote: On Thu, Mar 24, 2016 at 07:47:12PM +0200, Stanislav Kolotinskiy wrote: Thanks for noticing; the above explanation however does not make it very clear why the symptom exhibits itself o