Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Junio C Hamano
Johannes Schindelin writes: > Hi, > > On Wed, 24 Feb 2016, Johannes Schindelin wrote: > >> I created a test and essentially duplicated Peff's finding: this is a >> Windows-only issue. > > Indeed it is in our patches: > > https://github.com/git-for-windows/git/commit/3a4c37b22 > > (short ver

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Jeff King
On Wed, Feb 24, 2016 at 01:13:39PM +0100, Johannes Schindelin wrote: > > I created a test and essentially duplicated Peff's finding: this is a > > Windows-only issue. > > Indeed it is in our patches: > > https://github.com/git-for-windows/git/commit/3a4c37b22 > > (short version: we carry

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Johannes Schindelin
Hi, On Wed, 24 Feb 2016, Johannes Schindelin wrote: > I created a test and essentially duplicated Peff's finding: this is a > Windows-only issue. Indeed it is in our patches: https://github.com/git-for-windows/git/commit/3a4c37b22 (short version: we carry some patches that simplify loc

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Johannes Schindelin
Hi Peff, John & Junio (who recommended GIT_CEILING_DIRECTORIES first, On Wed, 24 Feb 2016, Jeff King wrote: > On Wed, Feb 24, 2016 at 10:14:03AM +, John Keeping wrote: > > > On Wed, Feb 24, 2016 at 03:26:57AM -0500, Jeff King wrote: > > > On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Sc

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Duy Nguyen
On Wed, Feb 24, 2016 at 3:26 PM, Jeff King wrote: > On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Schindelin wrote: > >> It is a pilot error to call `git config section.key value` outside of >> any Git worktree. >> >> Let's report that error instead of creating the .git/ directory and >> writ

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Jeff King
On Wed, Feb 24, 2016 at 10:14:03AM +, John Keeping wrote: > On Wed, Feb 24, 2016 at 03:26:57AM -0500, Jeff King wrote: > > On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Schindelin wrote: > > > > > I cannot think of a way how to test this: all of the regression > > > tests run inside

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread John Keeping
On Wed, Feb 24, 2016 at 03:26:57AM -0500, Jeff King wrote: > On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Schindelin wrote: > > > I cannot think of a way how to test this: all of the regression > > tests run inside Git's own worktree, and we cannot even assume > > that /tmp/ is o

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Jeff King
On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Schindelin wrote: > It is a pilot error to call `git config section.key value` outside of > any Git worktree. > > Let's report that error instead of creating the .git/ directory and > writing a fresh config into it. Hmm. I get (on my Linux mach

[PATCH] git config: do not create .git/ if it does not exist yet

2016-02-23 Thread Johannes Schindelin
It is a pilot error to call `git config section.key value` outside of any Git worktree. Let's report that error instead of creating the .git/ directory and writing a fresh config into it. This addresses https://github.com/git-for-windows/git/issues/643 and https://groups.google.com/forum/#!topic/