Re: [PATCH] git.el: handle default excludesfile properly

On Wed, Mar 07 2018, Dorab Patel jotted: > Thanks for updating us with the status of git.el. > > The last time I looked at magit, it was too heavyweight for my needs. > I like the simplicity of git.el. But perhaps it's time for me to take > another look at magit. You can also check out the VC

Re: [PATCH] git.el: handle default excludesfile properly

Thanks for updating us with the status of git.el. The last time I looked at magit, it was too heavyweight for my needs. I like the simplicity of git.el. But perhaps it's time for me to take another look at magit. On Tue, Mar 6, 2018 at 3:54 AM, Alexandre Julliard wrote: >

Re: [PATCH] git.el: handle default excludesfile properly

Junio C Hamano writes: > Having said that, I am sorry to say that I am not sure if the copy > we have is the one to be patched, so I would appreciate if Alexandre > (cc'ed) can clarify the situation. The last change done to our copy > of the script is from 2012, and I do not

Re: [PATCH] git.el: handle default excludesfile properly

Dorab Patel writes: > Looking deeper into how the function git-get-exclude-files is used, I > see that it is only being called from git-run-ls-files-with-excludes. > So, perhaps, a better (or additional) fix might be to add the > parameter "--exclude-standard" in the call

Re: [PATCH] git.el: handle default excludesfile properly

On Sat, Mar 3, 2018 at 9:57 PM, Dorab Patel wrote: > Thanks for reviewing and locating the commits. > > OK, I'll re-roll and add the relevant commits. It may take some time. > > Should I just send the revised patch as a separate thread (with the > relevant commits and

Re: [PATCH] git.el: handle default excludesfile properly

Thanks for reviewing and locating the commits. OK, I'll re-roll and add the relevant commits. It may take some time. Should I just send the revised patch as a separate thread (with the relevant commits and history)? On Sat, Mar 3, 2018 at 6:12 PM, Eric Sunshine wrote:

Re: [PATCH] git.el: handle default excludesfile properly

On Sat, Mar 3, 2018 at 8:36 PM, Dorab Patel wrote: > Correct me if I'm wrong, but my understanding, from > https://git-scm.com/docs/gitignore, is that $HOME/.gitignore is used > only if it is specified as the value of core.excludesfile in > ~/.gitconfig. It is not used by

Re: [PATCH] git.el: handle default excludesfile properly

[[Pardon the duplicate. I forgot to send via text/plain and the mailing list bounced it, so resending.]] Thanks for the feedback. Correct me if I'm wrong, but my understanding, from https://git-scm.com/docs/gitignore, is that $HOME/.gitignore is used only if it is specified as the value of

Re: [PATCH] git.el: handle default excludesfile properly

On Fri, Mar 2, 2018 at 10:48 PM, Dorab Patel wrote: > The previous version only looked at core.excludesfile for locating the > excludesfile. So, when core.excludesfile was not defined, it did not > use the possible default locations. > > The current version uses either

[PATCH] git.el: handle default excludesfile properly

The previous version only looked at core.excludesfile for locating the excludesfile. So, when core.excludesfile was not defined, it did not use the possible default locations. The current version uses either $XDG_CONFIG_HOME/git/ignore or $HOME/.config/git/ignore for the default excludesfile