Re: [PATCH] gitweb: Harden UTF-8 handling in generated links

2014-06-04 Thread Michael Wagner
On Wed, Jun 04, 2014 at 08:47:54PM +0200, Jakub Narębski wrote: > Michael Wagner wrote: > > On Tue, May 27, 2014 at 04:22:42PM +0200, Jakub Narębski wrote: > > >> Subject: [PATCH] gitweb: Harden UTF-8 handling in generated links > >> > >> esc_html() e

Re: [PATCH] gitweb: Harden UTF-8 handling in generated links

2014-06-04 Thread Jakub Narębski
Michael Wagner wrote: > On Tue, May 27, 2014 at 04:22:42PM +0200, Jakub Narębski wrote: >> Subject: [PATCH] gitweb: Harden UTF-8 handling in generated links >> >> esc_html() ensures that its input is properly UTF-8 encoded and marked >> as UTF-8 with to_utf8(). Make

Re: [PATCH] gitweb: Harden UTF-8 handling in generated links

2014-06-04 Thread Michael Wagner
':utf8'; > > > > like in the rest of the code. > > > >> @entries = map { chomp; $_ } <$fd>; > >> > > > > Even better solution would be to use > > > > use open IN => ':encoding(utf-8)';

[PATCH] gitweb: Harden UTF-8 handling in generated links

2014-05-27 Thread Jakub Narębski
gt; > use open IN => ':encoding(utf-8)'; > > at the beginning of gitweb.perl, once and for all. Or harden esc_param / esc_path_info the same way esc_html is hardened against missing ':utf8' flag. -- >8 -- Subject: [PATCH] gitweb: Harden UTF-8 handling in gen