Re: [PATCH] gitweb: escape link body in format_ref_marker

2016-08-02 Thread Andreas Brauchli
On Mon, Aug 1, 2016 at 9:54 PM, Junio C Hamano wrote: > Jakub Narębski writes: > >> Good catch! >> >> Acked-by: Jakub Narębski > > Sigh; the contents may be good but the patch is unusable as-is > because of heavy whitespace damage. > > I'll fix it up. Thanks, both. My apologies for that, it see

Re: [PATCH] gitweb: escape link body in format_ref_marker

2016-08-01 Thread Junio C Hamano
Jakub Narębski writes: > Good catch! > > Acked-by: Jakub Narębski Sigh; the contents may be good but the patch is unusable as-is because of heavy whitespace damage. I'll fix it up. Thanks, both. >> --- >> gitweb/gitweb.perl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> dif

Re: [PATCH] gitweb: escape link body in format_ref_marker

2016-07-30 Thread Jakub Narębski
W dniu 29.07.2016 o 16:49, Andreas Brauchli pisze: > Fix a case where an html link can be generated from unescaped input > resulting in invalid strict xhtml or potentially injected code. > > An overview of a repo with a tag "1.0.0&0.0.1" would previously result > in an unescaped amperstand in the

[PATCH] gitweb: escape link body in format_ref_marker

2016-07-29 Thread Andreas Brauchli
Fix a case where an html link can be generated from unescaped input resulting in invalid strict xhtml or potentially injected code. An overview of a repo with a tag "1.0.0&0.0.1" would previously result in an unescaped amperstand in the link body. Signed-off-by: Andreas Brauchli --- gitweb/gitw