Re: [PATCH] gpg-interface: Add some output from gpg when it errors out.

2017-01-26 Thread Junio C Hamano
Mike Hommey writes: >> With that information recorded in the log (or in-code comment, or >> both), if it turns out that some lines with the prefix are useful >> (or some other lines without the prefix are not very useful), they >> can tweak the filtering criteria as

Re: [PATCH] gpg-interface: Add some output from gpg when it errors out.

2017-01-25 Thread Jeff King
On Thu, Jan 26, 2017 at 08:54:10AM +0900, Mike Hommey wrote: > > Implementation-wise, I'd be happier if we do not add any new > > callsites of strbuf_split(), which is a horrible interface. But > > that is a minor detail. > > What would you suggest otherwise? Try string_list_split() (or its

Re: [PATCH] gpg-interface: Add some output from gpg when it errors out.

2017-01-25 Thread Mike Hommey
On Wed, Jan 25, 2017 at 06:37:55PM -0800, Junio C Hamano wrote: > Mike Hommey writes: > > > On Wed, Jan 25, 2017 at 03:04:38PM -0800, Junio C Hamano wrote: > > ... > >> Overall I think this is a good thing to do. Instead of eating the > >> status output, showing what we got,

Re: [PATCH] gpg-interface: Add some output from gpg when it errors out.

2017-01-25 Thread Junio C Hamano
Mike Hommey writes: > On Wed, Jan 25, 2017 at 03:04:38PM -0800, Junio C Hamano wrote: > ... >> Overall I think this is a good thing to do. Instead of eating the >> status output, showing what we got, especially when we know the >> command failed, would make the bug-hunting of

Re: [PATCH] gpg-interface: Add some output from gpg when it errors out.

2017-01-25 Thread Mike Hommey
On Wed, Jan 25, 2017 at 03:04:38PM -0800, Junio C Hamano wrote: > Mike Hommey writes: > > > For instance, after changing my laptop for a new one, I copied my > > configs, but had some environment differences that broke gpg. > > With this change applied, the output becomes, on

Re: [PATCH] gpg-interface: Add some output from gpg when it errors out.

2017-01-25 Thread Junio C Hamano
Mike Hommey writes: > For instance, after changing my laptop for a new one, I copied my > configs, but had some environment differences that broke gpg. > With this change applied, the output becomes, on this new machine: > gpg: keyblock resource

[PATCH] gpg-interface: Add some output from gpg when it errors out.

2017-01-24 Thread Mike Hommey
When e.g. signing a tag fails, the user is left with the following output on their console: error: gpg failed to sign the data error: unable to sign the tag There is no indication of what specifically failed, and no indication how they might solve the problem. It turns out, gpg still does