Re: [PATCH] grep: remove "repo" arg from non-supporting funcs

2018-03-27 Thread Stefan Beller
On Tue, Mar 27, 2018 at 5:24 PM, Jonathan Tan wrote: > On Tue, 27 Mar 2018 16:20:25 -0700 > Stefan Beller wrote: > >> On Tue, Mar 27, 2018 at 3:58 PM, Jonathan Tan >> wrote: >> > As part of commit f9ee2fcdfa ("grep: recurse in-process using 'struct >> > repository'", 2017-08-02), many functions

Re: [PATCH] grep: remove "repo" arg from non-supporting funcs

2018-03-27 Thread Jonathan Tan
On Tue, 27 Mar 2018 16:20:25 -0700 Stefan Beller wrote: > On Tue, Mar 27, 2018 at 3:58 PM, Jonathan Tan > wrote: > > As part of commit f9ee2fcdfa ("grep: recurse in-process using 'struct > > repository'", 2017-08-02), many functions in builtin/grep.c were > > converted to also take "struct repo

Re: [PATCH] grep: remove "repo" arg from non-supporting funcs

2018-03-27 Thread Stefan Beller
On Tue, Mar 27, 2018 at 3:58 PM, Jonathan Tan wrote: > As part of commit f9ee2fcdfa ("grep: recurse in-process using 'struct > repository'", 2017-08-02), many functions in builtin/grep.c were > converted to also take "struct repository *" arguments. Among them were > grep_object() and grep_objects

[PATCH] grep: remove "repo" arg from non-supporting funcs

2018-03-27 Thread Jonathan Tan
As part of commit f9ee2fcdfa ("grep: recurse in-process using 'struct repository'", 2017-08-02), many functions in builtin/grep.c were converted to also take "struct repository *" arguments. Among them were grep_object() and grep_objects(). However, at least grep_objects() was converted incomplete