Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-02 Thread Kaartic Sivaraam
On Sat, 2017-07-01 at 13:31 -0700, Junio C Hamano wrote: > That sounds like a sample that is there not because it would be > useful, but because we couldn't think of any useful example. > > IOW, I view it just as useful as a sample that does > > #!/bin/sh > echo "# useless cruft"

Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-01 Thread Philip Oakley
From: "Junio C Hamano" "Philip Oakley" writes: From: "Junio C Hamano" Kaartic Sivaraam writes: By the way, the one that is still actually enabled is no longer needed. The commit template

Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-01 Thread Junio C Hamano
Kaartic Sivaraam writes: > On Sat, 2017-07-01 at 10:36 -0700, Junio C Hamano wrote: >> Actually I was wondering if it is a good idea to remove it, as it >> seems to have outlived its usefulness. > It does seem to be a good idea but it would leave the

Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-01 Thread Junio C Hamano
"Philip Oakley" writes: > From: "Junio C Hamano" >> Kaartic Sivaraam writes: >> By the way, the one that is still actually enabled is no longer needed. The commit template generated internally was corrected

Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-01 Thread Kaartic Sivaraam
On Sat, 2017-07-01 at 10:36 -0700, Junio C Hamano wrote: > Actually I was wondering if it is a good idea to remove it, as it > seems to have outlived its usefulness. It does seem to be a good idea but it would leave the 'prepare-commit- msg' hook with no scripts that could be used by just

Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-01 Thread Philip Oakley
From: "Junio C Hamano" Kaartic Sivaraam writes: By the way, the one that is still actually enabled is no longer needed. The commit template generated internally was corrected some time ago not to add the "Conflicts:" section without

Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-01 Thread Junio C Hamano
Kaartic Sivaraam writes: >> By the way, the one that is still actually enabled is no longer >> needed. The commit template generated internally was corrected some >> time ago not to add the "Conflicts:" section without commenting it >> out. >> > I'll send in

Re: [PATCH] hooks: add signature to the top of the commit message

2017-07-01 Thread Kaartic Sivaraam
On Fri, 2017-06-30 at 09:44 -0700, Junio C Hamano wrote: > It does look like a hack.  I was wondering if "interpret-trailers" > is mature enough and can be used for this by now. It does look promising except for a few differences from the hook which I'll explain in the following mail. >  Also the

Re: [PATCH] hooks: add signature to the top of the commit message

2017-06-30 Thread Junio C Hamano
Kaartic Sivaraam writes: > The sample hook to prepare the commit message before > a commit allows users to opt-in to add the signature > to the commit message. The signature is added at a place > that isn't consistent with the "-s" option of "git commit". >

[PATCH] hooks: add signature to the top of the commit message

2017-06-30 Thread Kaartic Sivaraam
The sample hook to prepare the commit message before a commit allows users to opt-in to add the signature to the commit message. The signature is added at a place that isn't consistent with the "-s" option of "git commit". Further, it could go out of view in certain cases. Add the signature to