Re: [PATCH] i18n: fix dangling dot in die() messages

2018-09-04 Thread Junio C Hamano
Jean-Noël Avila writes: > On 04/09/2018, Ævar Arnfjörð Bjarmason wrote:On Tue, Sep 4, 2018 at 4:59 > PM Jean-Noel Avila wrote: >> Your commit message says "dangling dot"... > > The dot is dangling on its own line. I don't really catch why this would > be needed. > >> >>> diff --git

Re: [PATCH] i18n: fix dangling dot in die() messages

2018-09-04 Thread Duy Nguyen
On Tue, Sep 4, 2018 at 5:08 PM Ævar Arnfjörð Bjarmason wrote: > > On Tue, Sep 4, 2018 at 4:59 PM Jean-Noel Avila wrote: > > Your commit message says "dangling dot"... > > > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > > index b56028ba9d..a011abfd7c 100644 > > ---

Re: [PATCH] i18n: fix dangling dot in die() messages

2018-09-04 Thread Jean-Noël Avila
On 04/09/2018, Ævar Arnfjörð Bjarmason wrote:On Tue, Sep 4, 2018 at 4:59 PM Jean-Noel Avila wrote: > Your commit message says "dangling dot"... The dot is dangling on its own line. I don't really catch why this would be needed. > >> diff --git a/builtin/submodule--helper.c

Re: [PATCH] i18n: fix dangling dot in die() messages

2018-09-04 Thread Ævar Arnfjörð Bjarmason
On Tue, Sep 4, 2018 at 4:59 PM Jean-Noel Avila wrote: Your commit message says "dangling dot"... > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index b56028ba9d..a011abfd7c 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -521,7

[PATCH] i18n: fix dangling dot in die() messages

2018-09-04 Thread Jean-Noel Avila
Signed-off-by: Jean-Noël Avila --- It is not clear what the style guide for messages is. builtin/submodule--helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index b56028ba9d..a011abfd7c 100644 ---