Re: [PATCH] log: add log.follow config option

2015-07-03 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: David Turner dtur...@twopensource.com writes: Twitter's history is almost completely linear, so it's useful for us. Since it looks like the patch won't be useful outside of our context, I'll just rewrite it to check the pathspec count, and

Re: [PATCH] log: add log.follow config option

2015-07-03 Thread Matthieu Moy
David Turner dtur...@twopensource.com writes: Twitter's history is almost completely linear, so it's useful for us. Since it looks like the patch won't be useful outside of our context, I'll just rewrite it to check the pathspec count, and not upstream it until follow becomes more general.

Re: [PATCH] log: add log.follow config option

2015-07-02 Thread David Turner
On Wed, 2015-07-01 at 14:19 -0700, Junio C Hamano wrote: Matthieu Moy matthieu@grenoble-inp.fr writes: So activating --follow for all git log calls would prevent log from being used with several pathspecs. Or, do you have a preparation patch that allows --follow with multiple

[PATCH] log: add log.follow config option

2015-07-01 Thread David Turner
Many users prefer to always use --follow with logs. Rather than aliasing the command, an option might be more convenient for some. Signed-off-by: David Turner dtur...@twopensource.com --- Why not just alias log=log --follow? At Twitter, we manage git config centrally, but we also allow users

Re: [PATCH] log: add log.follow config option

2015-07-01 Thread Matthieu Moy
David Turner dtur...@twopensource.com writes: diff --git a/builtin/log.c b/builtin/log.c index 8781049..11b8d82 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -31,6 +31,7 @@ static const char *default_date_mode = NULL; static int default_abbrev_commit; static int default_show_root

Re: [PATCH] log: add log.follow config option

2015-07-01 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: So activating --follow for all git log calls would prevent log from being used with several pathspecs. Or, do you have a preparation patch that allows --follow with multiple pathspecs? ;-) In any case, you have to test git log -- path1