Re: [PATCH] log -g: ignore revision parameters that have no reflog

2016-02-03 Thread Dennis Kaarsemaker
On di, 2016-02-02 at 16:21 -0800, Junio C Hamano wrote: > Dennis Kaarsemaker writes: > > > + if (revs->reflog_info) { > > + /* > > +  * The reflog iterator gets confused when fed > > things that don't > > +  * have reflogs. Help it along a

Re: [PATCH] log -g: ignore revision parameters that have no reflog

2016-02-03 Thread Junio C Hamano
Dennis Kaarsemaker writes: > It is not, the code should look for @{, not @. Not exactly. $ git show -s --format='%h %s' 'HEAD^{/@{3}}' -- 55d5d5b combine-diff.c: fix performance problem when folding ... The commit has a line with a string "@@@" on it and the

[PATCH] log -g: ignore revision parameters that have no reflog

2016-02-02 Thread Dennis Kaarsemaker
git log -g (and by extension, git reflog) gets mightly confused when trying to display the reflog of something that is not a ref that has a reflog. We can help by teaching handle_revision_arg to check all revision arguments for reflog existence if it's in reflog mode. git log -g

Re: [PATCH] log -g: ignore revision parameters that have no reflog

2016-02-02 Thread Junio C Hamano
Dennis Kaarsemaker writes: > + if (revs->reflog_info) { > + /* > + * The reflog iterator gets confused when fed things that don't > + * have reflogs. Help it along a bit > + */ > + if (strchr(arg, '@') !=