Re: [PATCH] ls-tree: make optional

2018-07-04 Thread Eric Sunshine
On Tue, Jul 3, 2018 at 7:57 PM Joshua Nelson wrote: > Use syntax similar to `git-checkout` to make optional for > `ls-tree`. If is omitted, default to HEAD. Infer arguments as > follows: > > 1. If args start with '--', assume to be HEAD > 2. If exactly one arg precedes '--', treat the argument

Re: [PATCH] ls-tree: make optional

2018-07-04 Thread Eric Sunshine
On Tue, Jul 3, 2018 at 8:05 PM Joshua Nelson wrote: > Is it customary to send a new patch or second patch that builds on the > first? It depends what you mean. If there were problems with a version of a patch you sent, then you "re-roll", which means you re-send the patch in its entirety as if it

Re: [PATCH] ls-tree: make optional

2018-07-03 Thread Joshua Nelson
On 07/03/2018 07:53 PM, Joshua Nelson wrote: > diff --git a/t/t3104-ls-tree-optional-args.sh > b/t/t3104-ls-tree-optional-args.sh > new file mode 100755 > index 0..e9d8389bc > --- /dev/null > +++ b/t/t3104-ls-tree-optional-args.sh > @@ -0,0 +1,63 @@ > +#!/bin/sh > + > +test_description='

[PATCH] ls-tree: make optional

2018-07-03 Thread Joshua Nelson
Use syntax similar to `git-checkout` to make optional for `ls-tree`. If is omitted, default to HEAD. Infer arguments as follows: 1. If args start with '--', assume to be HEAD 2. If exactly one arg precedes '--', treat the argument as 3. If more than one arg precedes '--', exit with an error 4.