Re: [PATCH] merge-recursive: remove superfluous semicolon

2018-09-05 Thread Elijah Newren
On Wed, Sep 5, 2018 at 9:55 AM Duy Nguyen wrote: > > On Wed, Sep 5, 2018 at 6:49 PM Elijah Newren wrote: > > > > Signed-off-by: Elijah Newren > > --- > > Once I saw it, I couldn't unsee it, and it quickly started getting on my > > nerves... > > Bad Elijah! Should have grepped and fixed all three

Re: [PATCH] merge-recursive: remove superfluous semicolon

2018-09-05 Thread Duy Nguyen
On Wed, Sep 5, 2018 at 6:49 PM Elijah Newren wrote: > > Signed-off-by: Elijah Newren > --- > Once I saw it, I couldn't unsee it, and it quickly started getting on my > nerves... Bad Elijah! Should have grepped and fixed all three ;-) $ git grep ';;$' -- '*.c' builtin/receive-pack.c: hmac_sha1(s

[PATCH] merge-recursive: remove superfluous semicolon

2018-09-05 Thread Elijah Newren
Signed-off-by: Elijah Newren --- Once I saw it, I couldn't unsee it, and it quickly started getting on my nerves... My bad for not noticing it when reviewing the original patch that introduced it, I guess -- 9da2d0379ea0 ("merge-recursive: use xstrdup() instead of fixed buffer", 2018-06-10) mer