Re: [PATCH] mingw: make stderr unbuffered again

Johannes Schindelin writes: > ... there is a different problem here: you stated very explicitly > that it is okay for `pu` to be broken [*1*]. If it were different, if any > breakage would imply that a fix is really, really required lest the patch > series be evicted

Re: [PATCH] mingw: make stderr unbuffered again

Hi Junio, On Wed, 15 Feb 2017, Junio C Hamano wrote: > Junio C Hamano writes: > > > Johannes Schindelin writes: > > > >> FWIW I wish it were different, that git.git's `master` reflected more > >> closely what the current Git for Windows version

Re: [PATCH] mingw: make stderr unbuffered again

Johannes Sixt writes: > Am 16.02.2017 um 18:10 schrieb Johannes Schindelin: >> On Wed, 15 Feb 2017, Johannes Sixt wrote: >>> I do not see how dup2() causes a change in stdio state. I >>> must be missing something (and that may be a basic misunderstanding of how >>> stdio is

Re: [PATCH] mingw: make stderr unbuffered again

Am 16.02.2017 um 18:10 schrieb Johannes Schindelin: On Wed, 15 Feb 2017, Johannes Sixt wrote: I do not see how dup2() causes a change in stdio state. I must be missing something (and that may be a basic misunderstanding of how stdio is initialized). It appears that dup2()ing fd 2 resets that

Re: [PATCH] mingw: make stderr unbuffered again

Hi Hannes, On Wed, 15 Feb 2017, Johannes Sixt wrote: > Am 15.02.2017 um 13:32 schrieb Johannes Schindelin: > > On Tue, 14 Feb 2017, Johannes Sixt wrote: > > > Am 14.02.2017 um 15:47 schrieb Johannes Schindelin: > > > > On Mon, 13 Feb 2017, Junio C Hamano wrote: > > > > > Johannes Schindelin

Re: [PATCH] mingw: make stderr unbuffered again

Junio C Hamano writes: > Johannes Schindelin writes: > >> FWIW I wish it were different, that git.git's `master` reflected more >> closely what the current Git for Windows version has. > > Well, we two wishing the same thing together without doing

Re: [PATCH] mingw: make stderr unbuffered again

Johannes Schindelin writes: > Hi Junio, > ... > The hat of a person who sees how patches are reviewed before they enter > pu/next/master/maint of git.git. > ... > make sense. This makes my life harder, but I believe that the alternative > would be *not* to have those

Re: [PATCH] mingw: make stderr unbuffered again

Am 15.02.2017 um 13:32 schrieb Johannes Schindelin: On Tue, 14 Feb 2017, Johannes Sixt wrote: Am 14.02.2017 um 15:47 schrieb Johannes Schindelin: On Mon, 13 Feb 2017, Junio C Hamano wrote: Johannes Schindelin writes: What we forgot was to mark stderr as

Re: [PATCH] mingw: make stderr unbuffered again

Hi Junio, On Tue, 14 Feb 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> OK. Should this go directly to 'master', as the isatty thing is > >> already in? > > > > From my point of view, it is not crucial. The next Git for Windows > > version will

Re: [PATCH] mingw: make stderr unbuffered again

Hi Hannes, On Tue, 14 Feb 2017, Johannes Sixt wrote: > Am 14.02.2017 um 15:47 schrieb Johannes Schindelin: > > On Mon, 13 Feb 2017, Junio C Hamano wrote: > > > Johannes Schindelin writes: > > > > When removing the hack for isatty(), we actually removed more than > >

Re: [PATCH] mingw: make stderr unbuffered again

Johannes Sixt writes: > Am 14.02.2017 um 15:47 schrieb Johannes Schindelin: > >>>From my point of view, it is not crucial. The next Git for Windows version >> will have it, of course, and Hannes is always running with his set of >> patches, he can easily cherry-pick this one, too.

Re: [PATCH] mingw: make stderr unbuffered again

Johannes Schindelin writes: >> OK. Should this go directly to 'master', as the isatty thing is >> already in? > > From my point of view, it is not crucial. The next Git for Windows version > will have it, of course, and Hannes is always running with his set of >

Re: [PATCH] mingw: make stderr unbuffered again

Am 14.02.2017 um 15:47 schrieb Johannes Schindelin: On Mon, 13 Feb 2017, Junio C Hamano wrote: Johannes Schindelin writes: When removing the hack for isatty(), we actually removed more than just an isatty() hack: we removed the hack where internal data structures

Re: [PATCH] mingw: make stderr unbuffered again

Hi Junio, On Mon, 13 Feb 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > When removing the hack for isatty(), we actually removed more than just > > an isatty() hack: we removed the hack where internal data structures of > > the MSVC runtime are

Re: [PATCH] mingw: make stderr unbuffered again

Johannes Schindelin writes: > When removing the hack for isatty(), we actually removed more than just > an isatty() hack: we removed the hack where internal data structures of > the MSVC runtime are modified in order to redirect stdout/stderr. > > Instead of using

[PATCH] mingw: make stderr unbuffered again

When removing the hack for isatty(), we actually removed more than just an isatty() hack: we removed the hack where internal data structures of the MSVC runtime are modified in order to redirect stdout/stderr. Instead of using that hack (that does not work with newer versions of the runtime,