Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2018-01-19 Thread Gargi Sharma
On Fri, Jan 19, 2018 at 9:46 PM, Jeff King wrote: > > On Mon, Jan 15, 2018 at 08:46:25PM -0500, Gargi Sharma wrote: > > > Replace the custom calls to mru.[ch] with calls to list.h. This patch is the > > final step in removing the mru API completely and inlining the logic. > > > >

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2018-01-19 Thread Jeff King
On Mon, Jan 15, 2018 at 08:46:25PM -0500, Gargi Sharma wrote: > Replace the custom calls to mru.[ch] with calls to list.h. This patch is the > final step in removing the mru API completely and inlining the logic. > > Another discussion, here >

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2018-01-19 Thread Junio C Hamano
Christian Couder writes: > On Tue, Jan 16, 2018 at 2:46 AM, Gargi Sharma wrote: >> Replace the custom calls to mru.[ch] with calls to list.h. This patch is the >> final step in removing the mru API completely and inlining the logic. > > You might

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2018-01-19 Thread Christian Couder
On Tue, Jan 16, 2018 at 2:46 AM, Gargi Sharma wrote: > Replace the custom calls to mru.[ch] with calls to list.h. This patch is the > final step in removing the mru API completely and inlining the logic. You might want to say that this provides a significant code reduction

[PATCH] mru: Replace mru.[ch] with list.h implementation

2018-01-15 Thread Gargi Sharma
Replace the custom calls to mru.[ch] with calls to list.h. This patch is the final step in removing the mru API completely and inlining the logic. Another discussion, here (https://public-inbox.org/git/caoci2dgyqr4jff5oby2buyhnjeaapqkf8tbojn2w0b18eo+...@mail.gmail.com/) was on what has to be done

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2017-12-12 Thread Оля Тележная
Gargi, If you have some difficulties - please feel free to ask questions (here or you can write me directly). I will be happy to help you. As I understand, you are super close to finish your first patch. Olga

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2017-11-12 Thread Jeff King
On Sun, Nov 12, 2017 at 12:49:17PM +, Gargi Sharma wrote: > > Sort of a side note, but seeing these two list pointers together makes > > me wonder what we should do with the list created by the "next" pointer. > > It seems like there are three options: > > > > 1. Convert it to "struct

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2017-11-12 Thread Gargi Sharma
On Sun, Nov 12, 2017 at 9:54 AM, Jeff King wrote: > On Sat, Nov 11, 2017 at 01:06:46PM -0500, Gargi Sharma wrote: > >> Replace custom allocation in mru.[ch] with generic calls >> to list.h API. >> >> Signed-off-by: Gargi Sharma > > Thanks, and welcome to the

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2017-11-12 Thread Jeff King
On Sun, Nov 12, 2017 at 09:54:35AM +, Jeff King wrote: > > @@ -1566,6 +1566,7 @@ struct pack_window { > > > > extern struct packed_git { > > struct packed_git *next; > > + struct list_head mru; > > struct pack_window *windows; > > off_t pack_size; > > const void

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2017-11-12 Thread Jeff King
On Sat, Nov 11, 2017 at 01:06:46PM -0500, Gargi Sharma wrote: > Replace custom allocation in mru.[ch] with generic calls > to list.h API. > > Signed-off-by: Gargi Sharma Thanks, and welcome to the git list. :) This looks like a good start on the topic, but I have a few

[PATCH] mru: Replace mru.[ch] with list.h implementation

2017-11-11 Thread Gargi Sharma
Replace custom allocation in mru.[ch] with generic calls to list.h API. Signed-off-by: Gargi Sharma --- builtin/pack-objects.c | 14 -- cache.h| 9 + mru.c | 27 --- mru.h | 40