Re: [PATCH] mv: let 'git mv file no-such-dir/' error out

2013-12-04 Thread Matthieu Moy
Duy Nguyen pclo...@gmail.com writes: On Tue, Dec 3, 2013 at 3:32 PM, Matthieu Moy matthieu@imag.fr wrote: Git used to trim the trailing slash, and make the command equivalent to 'git mv file no-such-dir', which created the file no-such-dir (while the trailing slash explicitly stated that

Re: [PATCH] mv: let 'git mv file no-such-dir/' error out

2013-12-04 Thread Duy Nguyen
On Wed, Dec 4, 2013 at 3:44 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Duy Nguyen pclo...@gmail.com writes: On Tue, Dec 3, 2013 at 3:32 PM, Matthieu Moy matthieu@imag.fr wrote: There's something we probably should check. In d78b0f3 ([PATCH] git-mv: add more path normalization -

Re: [PATCH] mv: let 'git mv file no-such-dir/' error out

2013-12-04 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Wed, Dec 4, 2013 at 3:44 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Duy Nguyen pclo...@gmail.com writes: On Tue, Dec 3, 2013 at 3:32 PM, Matthieu Moy matthieu@imag.fr wrote: There's something we probably should check. In d78b0f3 ([PATCH]

Re: [PATCH] mv: let 'git mv file no-such-dir/' error out

2013-12-04 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: It seems that t7001 needs some face-lifting, by the way. Perhaps after this patch solidifies. Yes. I followed the style of surrounding code, but it could be reformatted to follow the current standard. I have no time for it now. -- Matthieu Moy

Re: [PATCH] mv: let 'git mv file no-such-dir/' error out

2013-12-03 Thread Duy Nguyen
On Tue, Dec 3, 2013 at 3:32 PM, Matthieu Moy matthieu@imag.fr wrote: Git used to trim the trailing slash, and make the command equivalent to 'git mv file no-such-dir', which created the file no-such-dir (while the trailing slash explicitly stated that it could only be a directory). This