Re: [PATCH] name-rev: include taggerdate in considering the best name

2016-04-24 Thread Johannes Schindelin
Hi, [fixing Uwe's email address, as the address bounces that was recorded in the commit introducing the flawed behavior, and I failed to check mailmap earlier.] On Fri, 22 Apr 2016, Junio C Hamano wrote: > Linus Torvalds writes: > > > ... I think this is still

Re: [PATCH] name-rev: include taggerdate in considering the best name

2016-04-22 Thread Junio C Hamano
Linus Torvalds writes: > ... I think this is still the simplest model we can use > without trying to really do a topo-sort. And in many ways it's the > simplest one to explain to people too: "we try to use the oldest > reference we can find as a base for the

Re: [PATCH] name-rev: include taggerdate in considering the best name

2016-04-22 Thread Linus Torvalds
On Fri, Apr 22, 2016 at 11:11 AM, Jeff King wrote: > > I confirmed that it does find the "optimal" tag for the case we've been > discussing. Yes. I'm a bit more worried about the date behavior for projects that merge back stable branches into their development trees (is the

Re: [PATCH] name-rev: include taggerdate in considering the best name

2016-04-22 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> That turned out to be quite simple (I wasn't sure originally if we'd >> actually visit all of the tags, which is why I had conceived of this as >> an initial pass; but of course it makes sense that we'd have to

Re: [PATCH] name-rev: include taggerdate in considering the best name

2016-04-22 Thread Junio C Hamano
Jeff King writes: > That turned out to be quite simple (I wasn't sure originally if we'd > actually visit all of the tags, which is why I had conceived of this as > an initial pass; but of course it makes sense that we'd have to see all > of the tags in the existing code). > ... >

Re: [PATCH] name-rev: include taggerdate in considering the best name

2016-04-22 Thread Jeff King
On Fri, Apr 22, 2016 at 03:39:01PM +0200, Johannes Schindelin wrote: > We most likely want the oldest tag that contained the commit to be > reported. So let's remember the taggerdate, and make it more important > than anything else when choosing the best name for a given commit. > > Suggested by

[PATCH] name-rev: include taggerdate in considering the best name

2016-04-22 Thread Johannes Schindelin
We most likely want the oldest tag that contained the commit to be reported. So let's remember the taggerdate, and make it more important than anything else when choosing the best name for a given commit. Suggested by Linus Torvalds. Note that we need to update t9903 because it tested for the