RE: [PATCH] pack-objects: don't warn about bitmaps on incremental pack

2016-12-19 Thread David Turner
> diff --git a/builtin/gc.c b/builtin/gc.c index 069950d0b4..d3c978c765 > 100644 > --- a/builtin/gc.c > +++ b/builtin/gc.c > @@ -191,6 +191,11 @@ static void add_repack_all_option(void) > } > } > > +static void add_repack_incremental_option(void) > +{ > + argv_array_push(&repack, "--no-

Re: [PATCH] pack-objects: don't warn about bitmaps on incremental pack

2016-12-16 Thread Jeff King
On Fri, Dec 16, 2016 at 06:59:35PM -0500, David Turner wrote: > When running git pack-objects --incremental, we do not expect to be > able to write a bitmap; it is very likely that objects in the new pack > will have references to objects outside of the pack. So we don't need > to warn the user a

[PATCH] pack-objects: don't warn about bitmaps on incremental pack

2016-12-16 Thread David Turner
When running git pack-objects --incremental, we do not expect to be able to write a bitmap; it is very likely that objects in the new pack will have references to objects outside of the pack. So we don't need to warn the user about it. This warning was making its way into gc.log because auto-gc w